# HG changeset patch # User Sergey Kandaurov # Date 1679952992 -14400 # Node ID 0351dee227a8341e442feeb03920a46b259adeb5 # Parent 2a7fc70900a5b9e62b801c36c1098ae893cb5a17 Tests: unbreak tests with dynamic certificates on stable. In 74cffa9d4c43, ticket based session reuse is enabled in addition to using a shared SSL session cache. This changed how a session can be resumed in a different server: - for a session ID based resumption, it is resumed in the same context - when using session tickets, a key name is also checked for matching - with a ticket callback, this is skipped in favor of callback's logic This makes 'session id context match' tests fail with session tickets on stable since ticket key names are unique in distinct SSL contexts. On the other hand, tests pass on 1.23.2+ due to automatic ticket keys rotation that installs ticket callback, and using a common shared SSL session cache. diff --git a/ssl_certificate.t b/ssl_certificate.t --- a/ssl_certificate.t +++ b/ssl_certificate.t @@ -184,7 +184,15 @@ my ($s, $ssl) = get('default', 8080); my $ses = Net::SSLeay::get_session($ssl); like(get('default', 8080, $ses), qr/default:r/, 'session reused'); + +TODO: { +# ticket key name mismatch prevents session resumption +local $TODO = 'not yet' unless $t->has_version('1.23.2'); + like(get('default', 8081, $ses), qr/default:r/, 'session id context match'); + +} + like(get('default', 8082, $ses), qr/default:\./, 'session id context distinct'); # errors diff --git a/stream_ssl_certificate.t b/stream_ssl_certificate.t --- a/stream_ssl_certificate.t +++ b/stream_ssl_certificate.t @@ -161,7 +161,15 @@ my ($s, $ssl) = get('default', 8080); my $ses = Net::SSLeay::get_session($ssl); like(get('default', 8080, $ses), qr/default:r/, 'session reused'); + +TODO: { +# ticket key name mismatch prevents session resumption +local $TODO = 'not yet' unless $t->has_version('1.23.2'); + like(get('default', 8081, $ses), qr/default:r/, 'session id context match'); + +} + like(get('default', 8082, $ses), qr/default:\./, 'session id context distinct'); # errors