# HG changeset patch # User Sergey Kandaurov # Date 1442226393 -10800 # Node ID a16d4a76819765895e05caf82966877d1658f316 # Parent 3f4a132c6463263a475ce8ebd3b4315283979b4e Tests: removed HTTP/2 TODOs for now passing GOAWAY tests. diff --git a/h2.t b/h2.t --- a/h2.t +++ b/h2.t @@ -521,9 +521,6 @@ is($frame, undef, 'invalid index'); # An endpoint that encounters a connection error SHOULD first send a # GOAWAY frame <..> -TODO: { -local $TODO = 'not yet'; - ($frame) = grep { $_->{type} eq "GOAWAY" } @$frames; ok($frame, 'invalid index - GOAWAY'); @@ -538,8 +535,6 @@ ok($frame, 'invalid index - GOAWAY'); is($frame->{last_sid}, $sid, 'invalid index - GOAWAY last stream'); is($frame->{code}, 9, 'invalid index - GOAWAY COMPRESSION_ERROR'); -} - h2_ping($sess, 'SEE-THIS'); is(@{h2_read($sess, all => [{ type => 'PING' }])}, 0, 'invalid index - PING'); is($sess->{socket}->connected, undef, 'invalid index - connection close'); @@ -1603,9 +1598,6 @@ is($frame->{code}, 1, 'newline in reques # GOAWAY on SYN_STREAM with even StreamID -TODO: { -local $TODO = 'not yet'; - $sess = new_session(); new_stream($sess, { path => '/' }, 2); $frames = h2_read($sess, all => [{ type => 'GOAWAY' }]); @@ -1615,17 +1607,12 @@ ok($frame, 'even stream - GOAWAY frame') is($frame->{code}, 1, 'even stream - error code'); is($frame->{last_sid}, 0, 'even stream - last stream'); -} - # GOAWAY on SYN_STREAM with backward StreamID # 5.1.1. Stream Identifiers # The first use of a new stream identifier implicitly closes all # streams in the "idle" state <..> with a lower-valued stream identifier. -TODO: { -local $TODO = 'not yet'; - $sess = new_session(); $sid = new_stream($sess, { path => '/' }, 3); h2_read($sess, all => [{ sid => $sid, fin => 1 }]); @@ -1638,13 +1625,8 @@ ok($frame, 'backward stream - GOAWAY fra is($frame->{code}, 1, 'backward stream - error code'); is($frame->{last_sid}, $sid, 'backward stream - last stream'); -} - # GOAWAY on the second SYN_STREAM with same StreamID -TODO: { -local $TODO = 'not yet'; - $sess = new_session(); $sid = new_stream($sess, { path => '/' }); h2_read($sess, all => [{ sid => $sid, fin => 1 }]); @@ -1657,8 +1639,6 @@ ok($frame, 'dup stream - GOAWAY frame'); is($frame->{code}, 1, 'dup stream - error code'); is($frame->{last_sid}, $sid, 'dup stream - last stream'); -} - # missing mandatory request header ':scheme' TODO: { @@ -1696,16 +1676,11 @@ h2_read($sess, all => [{ sid => $sid, le $t->stop(); -TODO: { -local $TODO = 'not yet'; - $frames = h2_read($sess, all => [{ type => 'GOAWAY' }]); ($frame) = grep { $_->{type} eq "GOAWAY" } @$frames; ok($frame, 'GOAWAY on connection close'); -} - ############################################################################### sub h2_ping {