annotate contrib/README @ 9300:5be23505292b

SSI: fixed incorrect or duplicate stub output. Following 3518:eb3aaf8bd2a9 (0.8.37), r->request_output is only set if there are data in the first buffer sent in the subrequest. As a result, following the change mentioned this flag cannot be used to prevent duplicate ngx_http_ssi_stub_output() calls, since it is not set if there was already some output, but the first buffer was empty. Still, when there are multiple subrequests, even an empty subrequest response might be delayed by the postpone filter, leading to a second call of ngx_http_ssi_stub_output() during finalization from ngx_http_writer() the subreqest buffers are released by the postpone filter. Since r->request_output is not set after the first call, this resulted in duplicate stub output. Additionally, checking only the first buffer might be wrong in some unusual cases. For example, the first buffer might be empty if $r->flush() is called before printing any data in the embedded Perl module. Depending on the postpone_output value and corresponding sizes, this issue can result in either duplicate or unexpected stub output, or "zero size buf in writer" alerts. Following 8124:f5515e727656 (1.23.4), it became slightly easier to reproduce the issue, as empty static files and empty cache items now result in a response with an empty buffer. Before the change, an empty proxied response can be used to reproduce the issue. Fix is check all buffers and set r->request_output if any non-empty buffers are sent. This ensures that all unusual cases of non-empty responses are covered, and also that r->request_output will be set after the first stub output, preventing duplicate output. Reported by Jan Gassen.
author Maxim Dounin <mdounin@mdounin.ru>
date Thu, 04 Jul 2024 17:41:28 +0300
parents 1bdf906bba99
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
537
c9ad0d9c7d59 nginx-0.1.43-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents:
diff changeset
1
667
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
2 geo2nginx.pl by Andrei Nigmatulin
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
3
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
4 The perl script to convert CSV geoip database ( free download
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
5 at http://www.maxmind.com/app/geoip_country ) to format, suitable
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
6 for use by the ngx_http_geo_module.
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
7
537
c9ad0d9c7d59 nginx-0.1.43-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents:
diff changeset
8
667
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
9 unicode2nginx by Maxim Dounin
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
10
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
11 The perl script to convert unicode mappings ( available
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
12 at http://www.unicode.org/Public/MAPPINGS/ ) to the nginx
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
13 configuration file format.
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
14 Two generated full maps for windows-1251 and koi8-r.
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
15
5461
1bdf906bba99 Contrib: added vim to README.
Maxim Dounin <mdounin@mdounin.ru>
parents: 667
diff changeset
16
1bdf906bba99 Contrib: added vim to README.
Maxim Dounin <mdounin@mdounin.ru>
parents: 667
diff changeset
17 vim by Evan Miller
1bdf906bba99 Contrib: added vim to README.
Maxim Dounin <mdounin@mdounin.ru>
parents: 667
diff changeset
18
1bdf906bba99 Contrib: added vim to README.
Maxim Dounin <mdounin@mdounin.ru>
parents: 667
diff changeset
19 Syntax highlighting of nginx configuration for vim, to be
1bdf906bba99 Contrib: added vim to README.
Maxim Dounin <mdounin@mdounin.ru>
parents: 667
diff changeset
20 placed into ~/.vim/.
1bdf906bba99 Contrib: added vim to README.
Maxim Dounin <mdounin@mdounin.ru>
parents: 667
diff changeset
21