annotate src/core/ngx_murmurhash.h @ 9295:c5623963c29e
Upstream: fixed proxy_no_cache when caching errors.
Caching errors, notably intercepted errors and internally generated
502/504 errors, as well as handling of cache revalidation with 304,
did not take into account u->conf->no_cache predicates configured.
As a result, an error might be cached even if configuration explicitly
says not to. Fix is to check u->conf->no_cache in these cases.
To simplify usage in multiple places, checking u->conf->no_cache is now
done in a separate function. As a minor optimization, u->conf->no_cache
is only checked if u->cacheable is set.
As a side effect, this change also fixes caching errors after
proxy_cache_bypass. Also, during cache revalidation u->cacheable is
now tested, so 304 responses which disable caching won't extend
cacheability of stored responses.
Additionally, when caching internally generated 502/504 errors
u->cacheable is now explicitly updated from u->headers_in.no_cache and
u->headers_in.expired, restoring the behaviour before 8041:0784ab86ad08
(1.23.0) when an error happens while reading the response headers.
Reported by Kirill A. Korinsky,
https://freenginx.org/pipermail/nginx/2024-April/000082.html
author |
Maxim Dounin <mdounin@mdounin.ru> |
date |
Tue, 25 Jun 2024 21:44:50 +0300 |
parents |
709d7d24239d |
children |
|
rev |
line source |
3891
|
1
|
|
2 /*
|
|
3 * Copyright (C) Igor Sysoev
|
4412
|
4 * Copyright (C) Nginx, Inc.
|
3891
|
5 */
|
|
6
|
|
7
|
|
8 #ifndef _NGX_MURMURHASH_H_INCLUDED_
|
|
9 #define _NGX_MURMURHASH_H_INCLUDED_
|
|
10
|
|
11
|
|
12 #include <ngx_config.h>
|
|
13 #include <ngx_core.h>
|
|
14
|
|
15
|
|
16 uint32_t ngx_murmur_hash2(u_char *data, size_t len);
|
|
17
|
|
18
|
4575
|
19 #endif /* _NGX_MURMURHASH_H_INCLUDED_ */
|