Mercurial > hg > nginx
annotate src/os/unix/ngx_setproctitle.h @ 7951:c7a8bdf5af55
Changed ngx_chain_update_chains() to test tag first (ticket #2248).
Without this change, aio used with HTTP/2 can result in connection hang,
as observed with "aio threads; aio_write on;" and proxying (ticket #2248).
The problem is that HTTP/2 updates buffers outside of the output filters
(notably, marks them as sent), and then posts a write event to call
output filters. If a filter does not call the next one for some reason
(for example, because of an AIO operation in progress), this might
result in a state when the owner of a buffer already called
ngx_chain_update_chains() and can reuse the buffer, while the same buffer
is still sitting in the busy chain of some other filter.
In the particular case a buffer was sitting in output chain's ctx->busy,
and was reused by event pipe. Output chain's ctx->busy was permanently
blocked by it, and this resulted in connection hang.
Fix is to change ngx_chain_update_chains() to skip buffers from other
modules unconditionally, without trying to wait for these buffers to
become empty.
author | Maxim Dounin <mdounin@mdounin.ru> |
---|---|
date | Sat, 30 Oct 2021 02:39:19 +0300 |
parents | 16013b71feed |
children |
rev | line source |
---|---|
509 | 1 |
2 /* | |
3 * Copyright (C) Igor Sysoev | |
4412 | 4 * Copyright (C) Nginx, Inc. |
509 | 5 */ |
6 | |
7 | |
8 #ifndef _NGX_SETPROCTITLE_H_INCLUDED_ | |
9 #define _NGX_SETPROCTITLE_H_INCLUDED_ | |
10 | |
11 | |
12 #if (NGX_HAVE_SETPROCTITLE) | |
13 | |
14 /* FreeBSD, NetBSD, OpenBSD */ | |
15 | |
5826
16013b71feed
Added ngx_init_setproctitle() return code check.
Maxim Dounin <mdounin@mdounin.ru>
parents:
4412
diff
changeset
|
16 #define ngx_init_setproctitle(log) NGX_OK |
3285 | 17 #define ngx_setproctitle(title) setproctitle("%s", title) |
509 | 18 |
19 | |
515 | 20 #else /* !NGX_HAVE_SETPROCTITLE */ |
509 | 21 |
515 | 22 #if !defined NGX_SETPROCTITLE_USES_ENV |
509 | 23 |
24 #if (NGX_SOLARIS) | |
25 | |
515 | 26 #define NGX_SETPROCTITLE_USES_ENV 1 |
509 | 27 #define NGX_SETPROCTITLE_PAD ' ' |
28 | |
29 ngx_int_t ngx_init_setproctitle(ngx_log_t *log); | |
30 void ngx_setproctitle(char *title); | |
31 | |
515 | 32 #elif (NGX_LINUX) || (NGX_DARWIN) |
509 | 33 |
515 | 34 #define NGX_SETPROCTITLE_USES_ENV 1 |
35 #define NGX_SETPROCTITLE_PAD '\0' | |
36 | |
37 ngx_int_t ngx_init_setproctitle(ngx_log_t *log); | |
38 void ngx_setproctitle(char *title); | |
39 | |
40 #else | |
509 | 41 |
5826
16013b71feed
Added ngx_init_setproctitle() return code check.
Maxim Dounin <mdounin@mdounin.ru>
parents:
4412
diff
changeset
|
42 #define ngx_init_setproctitle(log) NGX_OK |
509 | 43 #define ngx_setproctitle(title) |
44 | |
515 | 45 #endif /* OSes */ |
46 | |
47 #endif /* NGX_SETPROCTITLE_USES_ENV */ | |
48 | |
49 #endif /* NGX_HAVE_SETPROCTITLE */ | |
509 | 50 |
51 | |
52 #endif /* _NGX_SETPROCTITLE_H_INCLUDED_ */ |