comparison src/os/unix/ngx_files.c @ 7668:0a04e5e4c40b

Large block sizes on Linux are now ignored (ticket #1168). NFS on Linux is known to report wsize as a block size (in both f_bsize and f_frsize, both in statfs() and statvfs()). On the other hand, typical file system block sizes on Linux (ext2/ext3/ext4, XFS) are limited to pagesize. (With FAT, block sizes can be at least up to 512k in extreme cases, but this doesn't really matter, see below.) To avoid too aggressive cache clearing on NFS volumes on Linux, block sizes larger than pagesize are now ignored. Note that it is safe to ignore large block sizes. Since 3899:e7cd13b7f759 (1.0.1) cache size is calculated based on fstat() st_blocks, and rounding to file system block size is preserved mostly for Windows. Note well that on other OSes valid block sizes seen are at least up to 65536. In particular, UFS on FreeBSD is known to work well with block and fragment sizes set to 65536.
author Maxim Dounin <mdounin@mdounin.ru>
date Mon, 22 Jun 2020 18:02:58 +0300
parents 577628e6b6a6
children ccb5ff87ab3e
comparison
equal deleted inserted replaced
7667:1ece2ac2555a 7668:0a04e5e4c40b
873 873
874 if ((fs.f_bsize % 512) != 0) { 874 if ((fs.f_bsize % 512) != 0) {
875 return 512; 875 return 512;
876 } 876 }
877 877
878 #if (NGX_LINUX)
879 if ((size_t) fs.f_bsize > ngx_pagesize) {
880 return 512;
881 }
882 #endif
883
878 return (size_t) fs.f_bsize; 884 return (size_t) fs.f_bsize;
879 } 885 }
880 886
881 #elif (NGX_HAVE_STATVFS) 887 #elif (NGX_HAVE_STATVFS)
882 888
891 897
892 if ((fs.f_frsize % 512) != 0) { 898 if ((fs.f_frsize % 512) != 0) {
893 return 512; 899 return 512;
894 } 900 }
895 901
902 #if (NGX_LINUX)
903 if ((size_t) fs.f_frsize > ngx_pagesize) {
904 return 512;
905 }
906 #endif
907
896 return (size_t) fs.f_frsize; 908 return (size_t) fs.f_frsize;
897 } 909 }
898 910
899 #else 911 #else
900 912