Mercurial > hg > nginx

comparison src/http/modules/ngx_http_scgi_module.c @ 4529:1ebec1d15a25

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Fixed incorrect ngx_cpystrn() usage in ngx_http_*_process_header(). This resulted in a disclosure of previously freed memory if upstream server returned specially crafted response, potentially exposing sensitive information. Reported by Matthew Daley.
author Maxim Dounin <mdounin@mdounin.ru>
date Thu, 15 Mar 2012 11:27:12 +0000
parents 14411ee4d89f
children 834049edae24
comparison
equal deleted inserted replaced
4528:00ccad19c53d 4529:1ebec1d15a25
939 } 939 }
940 940
941 h->value.data = h->key.data + h->key.len + 1; 941 h->value.data = h->key.data + h->key.len + 1;
942 h->lowcase_key = h->key.data + h->key.len + 1 + h->value.len + 1; 942 h->lowcase_key = h->key.data + h->key.len + 1 + h->value.len + 1;
943 943
944 ngx_cpystrn(h->key.data, r->header_name_start, h->key.len + 1); 944 ngx_memcpy(h->key.data, r->header_name_start, h->key.len);
945 ngx_cpystrn(h->value.data, r->header_start, h->value.len + 1); 945 h->key.data[h->key.len] = '\0';
946 ngx_memcpy(h->value.data, r->header_start, h->value.len);
947 h->value.data[h->value.len] = '\0';
946 948
947 if (h->key.len == r->lowcase_index) { 949 if (h->key.len == r->lowcase_index) {
948 ngx_memcpy(h->lowcase_key, r->lowcase_header, h->key.len); 950 ngx_memcpy(h->lowcase_key, r->lowcase_header, h->key.len);
949 951
950 } else { 952 } else {