Mercurial > hg > nginx

comparison src/event/ngx_event_pipe.c @ 4065:227a819b46db

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Proper setting of read->eof in pipe code. Setting read->eof to 0 seems to be just a typo. It appeared in nginx-0.0.1-2003-10-28-18:45:41 import (r164), while identical code in ngx_recv.c introduced in the same import do actually set read->eof to 1. Failure to set read->eof to 1 results in EOF not being generally detectable from connection flags. On the other hand, kqueue won't report any read events on such a connection since we use EV_CLEAR. This resulted in read timeouts if such connection was cached and used for another request.
author Maxim Dounin <mdounin@mdounin.ru>
date Thu, 01 Sep 2011 15:10:41 +0000
parents 6060225e9261
children 5db098f97e0e
comparison
equal deleted inserted replaced
4064:5b776ad53c3c 4065:227a819b46db
147 147
148 if (p->upstream->read->available == 0 148 if (p->upstream->read->available == 0
149 && p->upstream->read->pending_eof) 149 && p->upstream->read->pending_eof)
150 { 150 {
151 p->upstream->read->ready = 0; 151 p->upstream->read->ready = 0;
152 p->upstream->read->eof = 0; 152 p->upstream->read->eof = 1;
153 p->upstream_eof = 1; 153 p->upstream_eof = 1;
154 p->read = 1; 154 p->read = 1;
155 155
156 if (p->upstream->read->kq_errno) { 156 if (p->upstream->read->kq_errno) {
157 p->upstream->read->error = 1; 157 p->upstream->read->error = 1;