comparison src/os/unix/ngx_files.h @ 7669:52b34c3f89b4

Too large st_blocks values are now ignored (ticket #157). With XFS, using "allocsize=64m" mount option results in large preallocation being reported in the st_blocks as returned by fstat() till the file is closed. This in turn results in incorrect cache size calculations and wrong clearing based on max_size. To avoid too aggressive cache clearing on such volumes, st_blocks values which result in sizes larger than st_size and eight blocks (an arbitrary limit) are no longer trusted, and we use st_size instead. The ngx_de_fs_size() counterpart is intentionally not modified, as it is used on closed files and hence not affected by this problem.
author Maxim Dounin <mdounin@mdounin.ru>
date Mon, 22 Jun 2020 18:02:59 +0300
parents 061ec464813f
children ccb5ff87ab3e
comparison
equal deleted inserted replaced
7668:0a04e5e4c40b 7669:52b34c3f89b4
183 #define ngx_is_file(sb) (S_ISREG((sb)->st_mode)) 183 #define ngx_is_file(sb) (S_ISREG((sb)->st_mode))
184 #define ngx_is_link(sb) (S_ISLNK((sb)->st_mode)) 184 #define ngx_is_link(sb) (S_ISLNK((sb)->st_mode))
185 #define ngx_is_exec(sb) (((sb)->st_mode & S_IXUSR) == S_IXUSR) 185 #define ngx_is_exec(sb) (((sb)->st_mode & S_IXUSR) == S_IXUSR)
186 #define ngx_file_access(sb) ((sb)->st_mode & 0777) 186 #define ngx_file_access(sb) ((sb)->st_mode & 0777)
187 #define ngx_file_size(sb) (sb)->st_size 187 #define ngx_file_size(sb) (sb)->st_size
188 #define ngx_file_fs_size(sb) ngx_max((sb)->st_size, (sb)->st_blocks * 512) 188 #define ngx_file_fs_size(sb) \
189 (((sb)->st_blocks * 512 > (sb)->st_size \
190 && (sb)->st_blocks * 512 < (sb)->st_size + 8 * (sb)->st_blksize) \
191 ? (sb)->st_blocks * 512 : (sb)->st_size)
189 #define ngx_file_mtime(sb) (sb)->st_mtime 192 #define ngx_file_mtime(sb) (sb)->st_mtime
190 #define ngx_file_uniq(sb) (sb)->st_ino 193 #define ngx_file_uniq(sb) (sb)->st_ino
191 194
192 195
193 ngx_int_t ngx_create_file_mapping(ngx_file_mapping_t *fm); 196 ngx_int_t ngx_create_file_mapping(ngx_file_mapping_t *fm);