comparison src/http/modules/perl/ngx_http_perl_module.h @ 7525:575480d3fd01

Perl: propagate errors. When an error happens, the ctx->error bit is now set, and croak() is called to terminate further processing. The ctx->error bit is checked in ngx_http_perl_call_handler() to cancel further processing, and is also checked in various output functions - to make sure these won't be called if croak() was handled by an eval{} in perl code. In particular, this ensures that output chain won't be called after errors, as filters might not expect this to happen. This fixes some segmentation faults under low memory conditions. Also this stops request processing after filter finalization or request body reading errors. For cases where an HTTP error status can be additionally returned (for example, 416 (Requested Range Not Satisfiable) from the range filter), the ctx->status field is also added.
author Maxim Dounin <mdounin@mdounin.ru>
date Fri, 12 Jul 2019 13:56:21 +0300
parents deebe988cbd7
children 0cb693b4cbbb
comparison
equal deleted inserted replaced
7524:deebe988cbd7 7525:575480d3fd01
27 ngx_str_t redirect_uri; 27 ngx_str_t redirect_uri;
28 ngx_str_t redirect_args; 28 ngx_str_t redirect_args;
29 29
30 SV *next; 30 SV *next;
31 31
32 ngx_uint_t done; /* unsigned done:1; */ 32 ngx_int_t status;
33
34 unsigned done:1;
35 unsigned error:1;
33 36
34 ngx_array_t *variables; /* array of ngx_http_perl_var_t */ 37 ngx_array_t *variables; /* array of ngx_http_perl_var_t */
35 38
36 #if (NGX_HTTP_SSI) 39 #if (NGX_HTTP_SSI)
37 ngx_http_ssi_ctx_t *ssi; 40 ngx_http_ssi_ctx_t *ssi;