Mercurial > hg > nginx
comparison src/http/modules/ngx_http_grpc_module.c @ 7746:88eca63261c3
gRPC: RST_STREAM(NO_ERROR) handling after "trailer only" responses.
Similarly to the problem fixed in 2096b21fcd10 (ticket #1792),
when a "trailer only" gRPC response (that is, a response with the
END_STREAM flag in the HEADERS frame) was immediately followed by
RST_STREAM(NO_ERROR) in the data preread along with the response
header, RST_STREAM wasn't properly skipped and caused "upstream
rejected request with error 0" errors.
Observed with "unknown service" gRPC errors returned by grpc-go.
Fix is to set ctx->done if we are going to parse additional data,
so the RST_STREAM(NO_ERROR) is properly skipped. Additionally, now
ngx_http_grpc_filter() will complain about frames sent for closed
stream if there are any.
| author | Pavel Pautov <p.pautov@f5.com> |
|---|---|
| date | Wed, 18 Nov 2020 18:41:16 -0800 |
| parents | a46fcf101cfc |
| children | 7ce28b4cc57e |
comparison
equal
deleted
inserted
replaced
| 7745:f57a478aa16d | 7746:88eca63261c3 |
|---|---|
| 1967 "upstream prematurely closed stream"); | 1967 "upstream prematurely closed stream"); |
| 1968 return NGX_ERROR; | 1968 return NGX_ERROR; |
| 1969 } | 1969 } |
| 1970 | 1970 |
| 1971 u->length = 0; | 1971 u->length = 0; |
| 1972 ctx->done = 1; | |
| 1972 | 1973 |
| 1973 } else { | 1974 } else { |
| 1974 u->length = 1; | 1975 u->length = 1; |
| 1975 } | 1976 } |
| 1976 | 1977 |