Mercurial > hg > nginx
comparison src/http/modules/ngx_http_proxy_module.c @ 7884:b87b7092cedb
Improved logging of invalid headers.
In 71edd9192f24 logging of invalid headers which were rejected with the
NGX_HTTP_PARSE_INVALID_HEADER error was restricted to just the "client
sent invalid header line" message, without any attempts to log the header
itself.
This patch returns logging of the header up to the invalid character and
the character itself. The r->header_end pointer is now properly set
in all cases to make logging possible.
The same logging is also introduced when parsing headers from upstream
servers.
| author | Maxim Dounin <mdounin@mdounin.ru> |
|---|---|
| date | Mon, 28 Jun 2021 18:01:20 +0300 |
| parents | 52338ddf9e2f |
| children | 419c066cb710 |
comparison
equal
deleted
inserted
replaced
| 7883:41f4bd4c51f1 | 7884:b87b7092cedb |
|---|---|
| 2017 | 2017 |
| 2018 if (rc == NGX_AGAIN) { | 2018 if (rc == NGX_AGAIN) { |
| 2019 return NGX_AGAIN; | 2019 return NGX_AGAIN; |
| 2020 } | 2020 } |
| 2021 | 2021 |
| 2022 /* there was error while a header line parsing */ | 2022 /* rc == NGX_HTTP_PARSE_INVALID_HEADER */ |
| 2023 | 2023 |
| 2024 ngx_log_error(NGX_LOG_ERR, r->connection->log, 0, | 2024 ngx_log_error(NGX_LOG_INFO, r->connection->log, 0, |
| 2025 "upstream sent invalid header"); | 2025 "upstream sent invalid header: \"%*s\\x%02xd...\"", |
| 2026 r->header_end - r->header_name_start, | |
| 2027 r->header_name_start, *r->header_end); | |
| 2026 | 2028 |
| 2027 return NGX_HTTP_UPSTREAM_INVALID_HEADER; | 2029 return NGX_HTTP_UPSTREAM_INVALID_HEADER; |
| 2028 } | 2030 } |
| 2029 } | 2031 } |
| 2030 | 2032 |