comparison src/http/modules/ngx_http_range_filter_module.c @ 7054:e02555553d0b

Range filter: protect from total size overflows. The overflow can be used to circumvent the restriction on total size of ranges introduced in c2a91088b0c0 (1.1.2). Additionally, overflow allows producing ranges with negative start (such ranges can be created by using a suffix, "bytes=-100"; normally this results in 200 due to the total size check). These can result in the following errors in logs: [crit] ... pread() ... failed (22: Invalid argument) [alert] ... sendfile() failed (22: Invalid argument) When using cache, it can be also used to reveal cache file header. It is believed that there are no other negative effects, at least with standard nginx modules. In theory, this can also result in memory disclosure and/or segmentation faults if multiple ranges are allowed, and the response is returned in a single in-memory buffer. This never happens with standard nginx modules though, as well as known 3rd party modules. Fix is to properly protect from possible overflow when incrementing size.
author Maxim Dounin <mdounin@mdounin.ru>
date Tue, 11 Jul 2017 16:06:23 +0300
parents aeaac3ccee4f
children 887c8c58ffeb
comparison
equal deleted inserted replaced
7053:7f480434c7f2 7054:e02555553d0b
375 } 375 }
376 376
377 range->start = start; 377 range->start = start;
378 range->end = end; 378 range->end = end;
379 379
380 if (size > NGX_MAX_OFF_T_VALUE - (end - start)) {
381 return NGX_HTTP_RANGE_NOT_SATISFIABLE;
382 }
383
380 size += end - start; 384 size += end - start;
381 385
382 if (ranges-- == 0) { 386 if (ranges-- == 0) {
383 return NGX_DECLINED; 387 return NGX_DECLINED;
384 } 388 }