Mercurial > hg > nginx
comparison src/http/ngx_http_core_module.c @ 9261:f798ecafec05
Request body: error_page 413 handling with HTTP/2 and HTTP/3.
When the client_max_body_size limit in ngx_http_core_find_config_phase()
is hit, nginx calls the ngx_http_discard_request_body() function, which
normally sets the r->discard_body flag while discarding the body, and then
reduces the r->headers_in.content_length_n field to 0 when the body is
completely discarded. As such, the client_max_body_size check is skipped
if the request is redirected to an error page, and this makes it possible
to use "error_page 413" without additional settings.
This only works with HTTP/1.x though. The HTTP/2 and HTTP/3 request body
discarding code paths failed to set r->discard_body or reset
r->headers_in.content_length_n, so configuring "error_page 413" did notwork
without additionally clearing the client_max_body_size limit in the
location with error page.
Fix is to set r->headers_in.content_length_n to 0 in the HTTP/2 and HTTP/3
request body discarding code paths (if there is a body). This is essentially
what happens with HTTP/1.x when the body is completely discarded, and makes
it possible to use "error_page 413" with HTTP/2 and HTTP/3 without additional
settings.
Additionally, r->discard_body flag is also set. For HTTP/2, it is not needed,
but serves as an optimization. For HTTP/3, it ensures that the request body
cannot be read after it was discarded, thus bypassing the client_max_body_size
limit.
Further, the r->discard_body flag is now always set after the request body
is discarded (and not cleared once it is fully discarded). While the body
is being discarded, the new r->discarding_body flag is now used. This
slightly optimizes existing code paths in ngx_http_read_client_request_body()
and ngx_http_discard_request_body(), and also makes it easier to only set
ngx_http_discarded_request_body_handler() for HTTP/1.x.
author | Maxim Dounin <mdounin@mdounin.ru> |
---|---|
date | Sat, 27 Apr 2024 18:22:38 +0300 |
parents | a6649497a762 |
children | 199dc0d6b05b |
comparison
equal
deleted
inserted
replaced
9260:ac5635650bc6 | 9261:f798ecafec05 |
---|---|
2454 } | 2454 } |
2455 | 2455 |
2456 sr->internal = 1; | 2456 sr->internal = 1; |
2457 | 2457 |
2458 sr->discard_body = r->discard_body; | 2458 sr->discard_body = r->discard_body; |
2459 sr->discarding_body = r->discarding_body; | |
2459 sr->expect_tested = 1; | 2460 sr->expect_tested = 1; |
2460 sr->main_filter_need_in_memory = r->main_filter_need_in_memory; | 2461 sr->main_filter_need_in_memory = r->main_filter_need_in_memory; |
2461 | 2462 |
2462 sr->uri_changes = NGX_HTTP_MAX_URI_CHANGES + 1; | 2463 sr->uri_changes = NGX_HTTP_MAX_URI_CHANGES + 1; |
2463 sr->subrequests = r->subrequests - 1; | 2464 sr->subrequests = r->subrequests - 1; |