Mercurial > hg > nginx
comparison src/http/modules/ngx_http_fastcgi_module.c @ 4534:fb322541c548 stable-1.0
Merge of r4530, r4531: null character fixes.
*) Fixed incorrect ngx_cpystrn() usage in ngx_http_*_process_header().
This resulted in a disclosure of previously freed memory if upstream
server returned specially crafted response, potentially exposing
sensitive information.
Reported by Matthew Daley.
*) Headers with null character are now rejected.
Headers with NUL character aren't allowed by HTTP standard and may cause
various security problems. They are now unconditionally rejected.
| author | Maxim Dounin <mdounin@mdounin.ru> |
|---|---|
| date | Thu, 15 Mar 2012 11:41:43 +0000 |
| parents | 4919fb357a5d |
| children |
comparison
equal
deleted
inserted
replaced
| 4533:65ff9ed7feb2 | 4534:fb322541c548 |
|---|---|
| 1444 | 1444 |
| 1445 h->value.data = h->key.data + h->key.len + 1; | 1445 h->value.data = h->key.data + h->key.len + 1; |
| 1446 h->lowcase_key = h->key.data + h->key.len + 1 | 1446 h->lowcase_key = h->key.data + h->key.len + 1 |
| 1447 + h->value.len + 1; | 1447 + h->value.len + 1; |
| 1448 | 1448 |
| 1449 ngx_cpystrn(h->key.data, r->header_name_start, | 1449 ngx_memcpy(h->key.data, r->header_name_start, h->key.len); |
| 1450 h->key.len + 1); | 1450 h->key.data[h->key.len] = '\0'; |
| 1451 ngx_cpystrn(h->value.data, r->header_start, | 1451 ngx_memcpy(h->value.data, r->header_start, h->value.len); |
| 1452 h->value.len + 1); | 1452 h->value.data[h->value.len] = '\0'; |
| 1453 } | 1453 } |
| 1454 | 1454 |
| 1455 h->hash = r->header_hash; | 1455 h->hash = r->header_hash; |
| 1456 | 1456 |
| 1457 if (h->key.len == r->lowcase_index) { | 1457 if (h->key.len == r->lowcase_index) { |