Mercurial > hg > nginx
view src/core/ngx_crc.h @ 7746:88eca63261c3
gRPC: RST_STREAM(NO_ERROR) handling after "trailer only" responses.
Similarly to the problem fixed in 2096b21fcd10 (ticket #1792),
when a "trailer only" gRPC response (that is, a response with the
END_STREAM flag in the HEADERS frame) was immediately followed by
RST_STREAM(NO_ERROR) in the data preread along with the response
header, RST_STREAM wasn't properly skipped and caused "upstream
rejected request with error 0" errors.
Observed with "unknown service" gRPC errors returned by grpc-go.
Fix is to set ctx->done if we are going to parse additional data,
so the RST_STREAM(NO_ERROR) is properly skipped. Additionally, now
ngx_http_grpc_filter() will complain about frames sent for closed
stream if there are any.
author | Pavel Pautov <p.pautov@f5.com> |
---|---|
date | Wed, 18 Nov 2020 18:41:16 -0800 |
parents | d620f497c50f |
children |
line wrap: on
line source
/* * Copyright (C) Igor Sysoev * Copyright (C) Nginx, Inc. */ #ifndef _NGX_CRC_H_INCLUDED_ #define _NGX_CRC_H_INCLUDED_ #include <ngx_config.h> #include <ngx_core.h> /* 32-bit crc16 */ static ngx_inline uint32_t ngx_crc(u_char *data, size_t len) { uint32_t sum; for (sum = 0; len; len--) { /* * gcc 2.95.2 x86 and icc 7.1.006 compile * that operator into the single "rol" opcode, * msvc 6.0sp2 compiles it into four opcodes. */ sum = sum >> 1 | sum << 31; sum += *data++; } return sum; } #endif /* _NGX_CRC_H_INCLUDED_ */