Mercurial > hg > nginx
view src/os/unix/rfork_thread.S @ 5050:f9a29f401770 stable-1.2
Merge of r4983: crypt_r() error handling fixed.
The crypt_r() function returns NULL on errors, check it explicitly instead
of assuming errno will remain 0 if there are no errors (per POSIX, the
setting of errno after a successful call to a function is unspecified
unless the description of that function specifies that errno shall not
be modified).
Additionally, dropped unneeded ngx_set_errno(0) and fixed error handling
of memory allocation after normal crypt(), which was inapropriate and
resulted in null pointer dereference on allocation failures.
author | Maxim Dounin <mdounin@mdounin.ru> |
---|---|
date | Mon, 11 Feb 2013 12:37:06 +0000 |
parents | d620f497c50f |
children |
line wrap: on
line source
/* * Copyright (C) Igor Sysoev * Copyright (C) Nginx, Inc. */ #include <sys/syscall.h> #include <machine/asm.h> /* * rfork_thread(3) - rfork_thread(flags, stack, func, arg); */ #define KERNCALL int $0x80 ENTRY(rfork_thread) push %ebp mov %esp, %ebp push %esi mov 12(%ebp), %esi # the thread stack address sub $4, %esi mov 20(%ebp), %eax # the thread argument mov %eax, (%esi) sub $4, %esi mov 16(%ebp), %eax # the thread start address mov %eax, (%esi) push 8(%ebp) # rfork(2) flags push $0 mov $SYS_rfork, %eax KERNCALL jc error cmp $0, %edx jne child parent: add $8, %esp pop %esi leave ret child: mov %esi, %esp pop %eax call *%eax # call a thread start address ... add $4, %esp push %eax push $0 mov $SYS_exit, %eax # ... and exit(2) after a thread would return KERNCALL error: add $8, %esp pop %esi leave PIC_PROLOGUE /* libc's cerror: jmp PIC_PLT(HIDENAME(cerror)) */ push %eax call PIC_PLT(CNAME(__error)) pop %ecx PIC_EPILOGUE mov %ecx, (%eax) mov $-1, %eax mov $-1, %edx ret