# HG changeset patch # User Maxim Dounin # Date 1337276500 0 # Node ID 07f028df3879729040d59c4c22880677bfb4b7b0 # Parent 944839adc406f900d975a6a1218ea6ab93cd2a94 Fixed segfault with filter_finalize introduced in r4621 (1.3.0). Example configuration to reproduce: location /image/ { error_page 415 = /zero; image_filter crop 100 100; proxy_pass http://127.0.0.1:8080; proxy_store on; } location /zero { return 204; } The problem appeared if upstream returned (big enough) non-image file, causing 415 to be generated by image filter. diff --git a/src/http/ngx_http_request.c b/src/http/ngx_http_request.c --- a/src/http/ngx_http_request.c +++ b/src/http/ngx_http_request.c @@ -1933,8 +1933,6 @@ ngx_http_finalize_request(ngx_http_reque if (rc == NGX_OK && r->filter_finalize) { c->error = 1; - ngx_http_finalize_connection(r); - return; } if (rc == NGX_DECLINED) {