# HG changeset patch # User Valentin Bartenev # Date 1361625828 0 # Node ID 42a888fdad0ba007f57b8513ed33bcc57aafe9ef # Parent bebcc2f837d3696a753e913eb7a85006184bb52f Fixed potential segfault in ngx_http_keepalive_handler(). In case of error in the read event handling we close a connection by calling ngx_http_close_connection(), that also destroys connection pool. Thereafter, an attempt to free a buffer (added in r4892) that was allocated from the pool could cause SIGSEGV and is meaningless as well (the buffer already freed with the pool). diff --git a/src/http/ngx_http_request.c b/src/http/ngx_http_request.c --- a/src/http/ngx_http_request.c +++ b/src/http/ngx_http_request.c @@ -2758,6 +2758,7 @@ ngx_http_keepalive_handler(ngx_event_t * if (n == NGX_AGAIN) { if (ngx_handle_read_event(rev, 0) != NGX_OK) { ngx_http_close_connection(c); + return; } /*