# HG changeset patch # User Valentin Bartenev # Date 1480349961 -10800 # Node ID 52bd8cc17f34bbebcb4d2ce3651b40af7d572d55 # Parent 2c7a2d75938a31044552b0a6cd6edaebdaf0bd69 HTTP/2: fixed saving preread buffer to temp file (ticket #1143). Previously, a request body bigger than "client_body_buffer_size" wasn't written into a temporary file if it has been pre-read entirely. The preread buffer is freed after processing, thus subsequent use of it might result in sending corrupted body or cause a segfault. diff --git a/src/http/v2/ngx_http_v2.c b/src/http/v2/ngx_http_v2.c --- a/src/http/v2/ngx_http_v2.c +++ b/src/http/v2/ngx_http_v2.c @@ -3575,6 +3575,9 @@ ngx_http_v2_read_request_body(ngx_http_r rb->buf = ngx_create_temp_buf(r->pool, (size_t) len); } else { + /* enforce writing body to file */ + r->request_body_in_file_only = 1; + rb->buf = ngx_calloc_buf(r->pool); if (rb->buf != NULL) {