# HG changeset patch # User Maxim Dounin # Date 1383178580 -14400 # Node ID 6aa75f4982cece340f40b9f78a1eab0b44a7238a # Parent 2bb2571d6e3420bfa8b7a7fa277778ace9647d56 Gunzip: proper error handling on gunzipping an empty response. With previous code, an empty (malformed) response resulted in a request finalized without sending anything to a client. diff --git a/src/http/modules/ngx_http_gunzip_filter_module.c b/src/http/modules/ngx_http_gunzip_filter_module.c --- a/src/http/modules/ngx_http_gunzip_filter_module.c +++ b/src/http/modules/ngx_http_gunzip_filter_module.c @@ -500,9 +500,13 @@ ngx_http_gunzip_filter_inflate(ngx_http_ return NGX_OK; } - if (rc == Z_STREAM_END && ctx->flush == Z_FINISH - && ctx->zstream.avail_in == 0) - { + if (ctx->flush == Z_FINISH && ctx->zstream.avail_in == 0) { + + if (rc != Z_STREAM_END) { + ngx_log_error(NGX_LOG_ERR, r->connection->log, 0, + "inflate() returned %d on response end", rc); + return NGX_ERROR; + } if (ngx_http_gunzip_filter_inflate_end(r, ctx) != NGX_OK) { return NGX_ERROR;