# HG changeset patch # User Andrey Belov # Date 1343831828 0 # Node ID 6e37004865fbaaea2950cf0db9ddc599022d1c40 # Parent 3032f4854b818c1c507f3c69b67ee0bf501e1743 Reorder checks in ngx_shared_memory_add() for more consistent error messages. diff --git a/src/core/ngx_cycle.c b/src/core/ngx_cycle.c --- a/src/core/ngx_cycle.c +++ b/src/core/ngx_cycle.c @@ -1285,6 +1285,14 @@ ngx_shared_memory_add(ngx_conf_t *cf, ng continue; } + if (tag != shm_zone[i].tag) { + ngx_conf_log_error(NGX_LOG_EMERG, cf, 0, + "the shared memory zone \"%V\" is " + "already declared for a different use", + &shm_zone[i].shm.name); + return NULL; + } + if (size && size != shm_zone[i].shm.size) { ngx_conf_log_error(NGX_LOG_EMERG, cf, 0, "the size %uz of shared memory zone \"%V\" " @@ -1293,14 +1301,6 @@ ngx_shared_memory_add(ngx_conf_t *cf, ng return NULL; } - if (tag != shm_zone[i].tag) { - ngx_conf_log_error(NGX_LOG_EMERG, cf, 0, - "the shared memory zone \"%V\" is " - "already declared for a different use", - &shm_zone[i].shm.name); - return NULL; - } - return &shm_zone[i]; }