# HG changeset patch # User Vladimir Homutov # Date 1370264068 -14400 # Node ID 85e72ea8fbfd86e466bce79079e48a9c97cf18c9 # Parent a15e2ef8d73d1fc6dad562c7cba45d7acf7e1ef2 Core: fixed stderr redirection on win32 in ngx_reopen_files(). On win32 stderr was not redirected into a file specified by "error_log" while reopening files. Fix is to use platform-independent functions to work with stderr, as already used by ngx_init_cycle() and main() since rev. d8316f307b6a. diff --git a/src/core/ngx_cycle.c b/src/core/ngx_cycle.c --- a/src/core/ngx_cycle.c +++ b/src/core/ngx_cycle.c @@ -1228,16 +1228,13 @@ ngx_reopen_files(ngx_cycle_t *cycle, ngx file[i].fd = fd; } -#if !(NGX_WIN32) + if (cycle->log->file->fd != ngx_stderr) { - if (cycle->log->file->fd != STDERR_FILENO) { - if (dup2(cycle->log->file->fd, STDERR_FILENO) == -1) { - ngx_log_error(NGX_LOG_EMERG, cycle->log, ngx_errno, - "dup2(STDERR) failed"); + if (ngx_set_stderr(cycle->log->file->fd) == NGX_FILE_ERROR) { + ngx_log_error(NGX_LOG_ALERT, cycle->log, ngx_errno, + ngx_set_stderr_n " failed"); } } - -#endif }