# HG changeset patch # User Ruslan Ermilov # Date 1519217443 -10800 # Node ID 88aad69eccef0422719698b54c82e3a020c0fe93 # Parent c69c13f10502e6429458f3dca576a6a398140892 Geo: optimized configuration parser. If the geo block parser has failed, doing more things is pointless. diff --git a/src/http/modules/ngx_http_geo_module.c b/src/http/modules/ngx_http_geo_module.c --- a/src/http/modules/ngx_http_geo_module.c +++ b/src/http/modules/ngx_http_geo_module.c @@ -461,6 +461,10 @@ ngx_http_geo_block(ngx_conf_t *cf, ngx_c *cf = save; + if (rv != NGX_CONF_OK) { + goto failed; + } + geo->proxies = ctx.proxies; geo->proxy_recursive = ctx.proxy_recursive; @@ -555,7 +559,7 @@ ngx_http_geo_block(ngx_conf_t *cf, ngx_c ngx_destroy_pool(ctx.temp_pool); ngx_destroy_pool(pool); - return rv; + return NGX_CONF_OK; failed: diff --git a/src/stream/ngx_stream_geo_module.c b/src/stream/ngx_stream_geo_module.c --- a/src/stream/ngx_stream_geo_module.c +++ b/src/stream/ngx_stream_geo_module.c @@ -431,6 +431,10 @@ ngx_stream_geo_block(ngx_conf_t *cf, ngx *cf = save; + if (rv != NGX_CONF_OK) { + goto failed; + } + if (ctx.ranges) { if (ctx.high.low && !ctx.binary_include) { @@ -522,7 +526,7 @@ ngx_stream_geo_block(ngx_conf_t *cf, ngx ngx_destroy_pool(ctx.temp_pool); ngx_destroy_pool(pool); - return rv; + return NGX_CONF_OK; failed: