# HG changeset patch # User Ruslan Ermilov # Date 1364217289 0 # Node ID 9bcf89ca78d2ca244150895d7f9b6dc743a178fb # Parent 566cd32d8bacaf9eff5f352122957bac67ef03be Upstream: only call peer.free() if peer.get() selected a peer. diff --git a/src/http/ngx_http_upstream.c b/src/http/ngx_http_upstream.c --- a/src/http/ngx_http_upstream.c +++ b/src/http/ngx_http_upstream.c @@ -3147,14 +3147,16 @@ ngx_http_upstream_next(ngx_http_request_ ngx_http_busy_unlock(u->conf->busy_lock, &u->busy_lock); #endif - if (ft_type == NGX_HTTP_UPSTREAM_FT_HTTP_404) { - state = NGX_PEER_NEXT; - } else { - state = NGX_PEER_FAILED; - } - - if (ft_type != NGX_HTTP_UPSTREAM_FT_NOLIVE) { + if (u->peer.sockaddr) { + + if (ft_type == NGX_HTTP_UPSTREAM_FT_HTTP_404) { + state = NGX_PEER_NEXT; + } else { + state = NGX_PEER_FAILED; + } + u->peer.free(&u->peer, u->peer.data, state); + u->peer.sockaddr = NULL; } if (ft_type == NGX_HTTP_UPSTREAM_FT_TIMEOUT) { @@ -3314,8 +3316,9 @@ ngx_http_upstream_finalize_request(ngx_h u->finalize_request(r, rc); - if (u->peer.free) { + if (u->peer.free && u->peer.sockaddr) { u->peer.free(&u->peer, u->peer.data, 0); + u->peer.sockaddr = NULL; } if (u->peer.connection) {