# HG changeset patch # User Maxim Dounin # Date 1621383197 -10800 # Node ID ba8a8299b9043fa10f47226800d5fcf644f45558 # Parent 6a81d96d3733515253697f7d7b4615c37bcd4e3e Mail: optimized discarding invalid SMTP commands. There is no need to scan buffer from s->buffer->pos, as we already scanned the buffer till "p" and wasn't able to find an LF. There is no real need for this change in SMTP, since it is at most a microoptimization of a non-common code path. Similar code in IMAP, however, will have to start scanning from "p" to be correct, since there can be newlines in IMAP literals. diff --git a/src/mail/ngx_mail_parse.c b/src/mail/ngx_mail_parse.c --- a/src/mail/ngx_mail_parse.c +++ b/src/mail/ngx_mail_parse.c @@ -843,7 +843,7 @@ invalid: /* skip invalid command till LF */ - for (p = s->buffer->pos; p < s->buffer->last; p++) { + for ( /* void */ ; p < s->buffer->last; p++) { if (*p == LF) { s->state = sw_start; s->buffer->pos = p + 1;