# HG changeset patch # User Maxim Dounin # Date 1463576250 -10800 # Node ID c93e57ba301b7bf7bd9f5f36c5357cada1b22465 # Parent 282448777dc25a0fd8044be3f5682f17ecd77db1 Events: close descriptors on errors in ngx_epoll_test_rdhup(). diff --git a/src/event/modules/ngx_epoll_module.c b/src/event/modules/ngx_epoll_module.c --- a/src/event/modules/ngx_epoll_module.c +++ b/src/event/modules/ngx_epoll_module.c @@ -477,25 +477,26 @@ ngx_epoll_test_rdhup(ngx_cycle_t *cycle) if (epoll_ctl(ep, EPOLL_CTL_ADD, s[0], &ee) == -1) { ngx_log_error(NGX_LOG_ALERT, cycle->log, ngx_errno, "epoll_ctl() failed"); - return; + goto failed; } if (close(s[1]) == -1) { ngx_log_error(NGX_LOG_ALERT, cycle->log, ngx_errno, "close() failed"); - return; + s[1] = -1; + goto failed; } + s[1] = -1; + events = epoll_wait(ep, &ee, 1, 5000); if (events == -1) { ngx_log_error(NGX_LOG_ALERT, cycle->log, ngx_errno, "epoll_wait() failed"); - return; + goto failed; } - (void) close(s[0]); - if (events) { ngx_use_epoll_rdhup = ee.events & EPOLLRDHUP; @@ -507,6 +508,18 @@ ngx_epoll_test_rdhup(ngx_cycle_t *cycle) ngx_log_debug1(NGX_LOG_DEBUG_EVENT, cycle->log, 0, "testing the EPOLLRDHUP flag: %s", ngx_use_epoll_rdhup ? "success" : "fail"); + +failed: + + if (s[1] != -1 && close(s[1]) == -1) { + ngx_log_error(NGX_LOG_ALERT, cycle->log, ngx_errno, + "close() failed"); + } + + if (close(s[0]) == -1) { + ngx_log_error(NGX_LOG_ALERT, cycle->log, ngx_errno, + "close() failed"); + } } #endif