# HG changeset patch # User Valentin Bartenev # Date 1407928305 -14400 # Node ID e044893b4587e638fb0c2f3edc0163cff69ce9db # Parent ac3f78219f85121a3b272d9c9fd86d341f9244e1 Merged conditions in the ngx_*_sendfile_chain() functions. No functional changes. diff --git a/src/os/unix/ngx_darwin_sendfile_chain.c b/src/os/unix/ngx_darwin_sendfile_chain.c --- a/src/os/unix/ngx_darwin_sendfile_chain.c +++ b/src/os/unix/ngx_darwin_sendfile_chain.c @@ -75,8 +75,6 @@ ngx_darwin_sendfile_chain(ngx_connection trailer.nalloc = NGX_IOVS_PREALLOCATE; for ( ;; ) { - file = NULL; - file_size = 0; eintr = 0; prev_send = send; @@ -98,22 +96,21 @@ ngx_darwin_sendfile_chain(ngx_connection file_size = ngx_chain_coalesce_file(&cl, limit - send); send += file_size; - } - if (file && header.count == 0) { + if (header.count == 0) { - /* create the trailer iovec and coalesce the neighbouring bufs */ - - cl = ngx_output_chain_to_iovec(&trailer, cl, limit - send, c->log); + /* + * create the trailer iovec and coalesce the neighbouring bufs + */ - if (cl == NGX_CHAIN_ERROR) { - return NGX_CHAIN_ERROR; - } + cl = ngx_output_chain_to_iovec(&trailer, cl, limit - send, c->log); - send += trailer.size; - } + if (cl == NGX_CHAIN_ERROR) { + return NGX_CHAIN_ERROR; + } - if (file) { + send += trailer.size; + } /* * sendfile() returns EINVAL if sf_hdtr's count is 0, diff --git a/src/os/unix/ngx_freebsd_sendfile_chain.c b/src/os/unix/ngx_freebsd_sendfile_chain.c --- a/src/os/unix/ngx_freebsd_sendfile_chain.c +++ b/src/os/unix/ngx_freebsd_sendfile_chain.c @@ -79,8 +79,6 @@ ngx_freebsd_sendfile_chain(ngx_connectio trailer.nalloc = NGX_IOVS_PREALLOCATE; for ( ;; ) { - file = NULL; - file_size = 0; eintr = 0; prev_send = send; @@ -102,10 +100,6 @@ ngx_freebsd_sendfile_chain(ngx_connectio file_size = (size_t) ngx_chain_coalesce_file(&cl, limit - send); send += file_size; - } - - - if (file) { /* create the trailer iovec and coalesce the neighbouring bufs */ @@ -116,9 +110,6 @@ ngx_freebsd_sendfile_chain(ngx_connectio } send += trailer.size; - } - - if (file) { if (ngx_freebsd_use_tcp_nopush && c->tcp_nopush == NGX_TCP_NOPUSH_UNSET) diff --git a/src/os/unix/ngx_linux_sendfile_chain.c b/src/os/unix/ngx_linux_sendfile_chain.c --- a/src/os/unix/ngx_linux_sendfile_chain.c +++ b/src/os/unix/ngx_linux_sendfile_chain.c @@ -66,8 +66,6 @@ ngx_linux_sendfile_chain(ngx_connection_ header.nalloc = NGX_IOVS_PREALLOCATE; for ( ;; ) { - file = NULL; - file_size = 0; eintr = 0; prev_send = send; @@ -156,9 +154,6 @@ ngx_linux_sendfile_chain(ngx_connection_ file_size = (size_t) ngx_chain_coalesce_file(&cl, limit - send); send += file_size; - } - - if (file) { #if 1 if (file_size == 0) { ngx_debug_point();