# HG changeset patch # User Igor Sysoev # Date 1311074656 0 # Node ID f1f194ceab164cd54108559c7b718855a5ade4c1 # Parent bfab2536197baa8d9914f027401e871335ea2c53 fix segfault if cache key is larger than upstream buffer size patch by Lanshun Zhou diff --git a/src/http/ngx_http_upstream.c b/src/http/ngx_http_upstream.c --- a/src/http/ngx_http_upstream.c +++ b/src/http/ngx_http_upstream.c @@ -661,6 +661,15 @@ ngx_http_upstream_cache(ngx_http_request ngx_http_file_cache_create_key(r); + if (r->cache->header_start >= u->conf->buffer_size) { + ngx_log_error(NGX_LOG_ERR, r->connection->log, 0, + "cache key too large, increase upstream buffer size %uz", + u->conf->buffer_size); + + r->cache = NULL; + return NGX_DECLINED; + } + switch (ngx_http_test_predicates(r, u->conf->cache_bypass)) { case NGX_ERROR: