# HG changeset patch
# User Roman Arutyunyan <arut@nginx.com>
# Date 1625050058 -10800
# Node ID f8ad3dd142ad01842cf9d792eff4eb0c2cc8a477
# Parent  e96c20b6f655cc1b882b3f677169c74f64576211
QUIC: consider max_ack_delay=16384 invalid.

As per RFC 9000:

   Values of 2^14 or greater are invalid.

diff --git a/src/event/quic/ngx_event_quic.c b/src/event/quic/ngx_event_quic.c
--- a/src/event/quic/ngx_event_quic.c
+++ b/src/event/quic/ngx_event_quic.c
@@ -176,7 +176,7 @@ ngx_quic_apply_transport_params(ngx_conn
         return NGX_ERROR;
     }
 
-    if (ctp->max_ack_delay > 16384) {
+    if (ctp->max_ack_delay >= 16384) {
         qc->error = NGX_QUIC_ERR_TRANSPORT_PARAMETER_ERROR;
         qc->error_reason = "invalid max_ack_delay";
 
diff --git a/src/http/modules/ngx_http_quic_module.c b/src/http/modules/ngx_http_quic_module.c
--- a/src/http/modules/ngx_http_quic_module.c
+++ b/src/http/modules/ngx_http_quic_module.c
@@ -394,7 +394,7 @@ ngx_http_quic_max_ack_delay(ngx_conf_t *
 {
     ngx_msec_t *sp = data;
 
-    if (*sp > 16384) {
+    if (*sp >= 16384) {
         ngx_conf_log_error(NGX_LOG_EMERG, cf, 0,
                            "\"quic_max_ack_delay\" must be less than 16384");
 
diff --git a/src/stream/ngx_stream_quic_module.c b/src/stream/ngx_stream_quic_module.c
--- a/src/stream/ngx_stream_quic_module.c
+++ b/src/stream/ngx_stream_quic_module.c
@@ -354,7 +354,7 @@ ngx_stream_quic_max_ack_delay(ngx_conf_t
 {
     ngx_msec_t *sp = data;
 
-    if (*sp > 16384) {
+    if (*sp >= 16384) {
         ngx_conf_log_error(NGX_LOG_EMERG, cf, 0,
                            "\"quic_max_ack_delay\" must be less than 16384");