Mercurial > hg > nginx

changeset 6974:289403abc84e

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Core: improved JSON escaping. Two-character representations are now used for \b, \f, \n, \r, and \t.
author Valentin Bartenev <vbart@nginx.com>
date Wed, 12 Apr 2017 22:47:57 +0300
parents 99934aade555
children d7ce41bdf050
files src/core/ngx_string.c
diffstat 1 files changed, 44 insertions(+), 7 deletions(-) [+]
line wrap: on
line diff
--- a/src/core/ngx_string.c
+++ b/src/core/ngx_string.c
@@ -1808,7 +1808,19 @@ ngx_escape_json(u_char *dst, u_char *src
                 len++;
 
             } else if (ch <= 0x1f) {
-                len += sizeof("\\u001F") - 2;
+
+                switch (ch) {
+                case '\n':
+                case '\r':
+                case '\t':
+                case '\b':
+                case '\f':
+                    len++;
+                    break;
+
+                default:
+                    len += sizeof("\\u001F") - 2;
+                }
             }
 
             size--;
@@ -1829,12 +1841,37 @@ ngx_escape_json(u_char *dst, u_char *src
             *dst++ = ch;
 
         } else {
-            *dst++ = '\\'; *dst++ = 'u'; *dst++ = '0'; *dst++ = '0';
-            *dst++ = '0' + (ch >> 4);
-
-            ch &= 0xf;
-
-            *dst++ = (ch < 10) ? ('0' + ch) : ('A' + ch - 10);
+            *dst++ = '\\';
+
+            switch (ch) {
+            case '\n':
+                *dst++ = 'n';
+                break;
+
+            case '\r':
+                *dst++ = 'r';
+                break;
+
+            case '\t':
+                *dst++ = 't';
+                break;
+
+            case '\b':
+                *dst++ = 'b';
+                break;
+
+            case '\f':
+                *dst++ = 'f';
+                break;
+
+            default:
+                *dst++ = 'u'; *dst++ = '0'; *dst++ = '0';
+                *dst++ = '0' + (ch >> 4);
+
+                ch &= 0xf;
+
+                *dst++ = (ch < 10) ? ('0' + ch) : ('A' + ch - 10);
+            }
         }
 
         size--;