Mercurial > hg > nginx
changeset 8863:33578b8d453d quic
HTTP/3: fixed ngx_stat_active counter.
Previously the counter was not incremented for HTTP/3 streams, but still
decremented in ngx_http_close_connection(). There are two solutions here, one
is to increment the counter for HTTP/3 streams, and the other one is not to
decrement the counter for HTTP/3 streams. The latter solution looks
inconsistent with ngx_stat_reading/ngx_stat_writing, which are incremented on a
per-request basis. The change adds ngx_stat_active increment for HTTP/3
request and push streams.
| author | Roman Arutyunyan <arut@nginx.com> |
|---|---|
| date | Wed, 22 Sep 2021 14:08:21 +0300 |
| parents | 3fdf0afd5d45 |
| children | ea9b645472b5 |
| files | src/http/v3/ngx_http_v3_filter_module.c src/http/v3/ngx_http_v3_request.c |
| diffstat | 2 files changed, 8 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/src/http/v3/ngx_http_v3_filter_module.c +++ b/src/http/v3/ngx_http_v3_filter_module.c @@ -896,6 +896,10 @@ ngx_http_v3_create_push_request(ngx_http return NGX_ABORT; } +#if (NGX_STAT_STUB) + (void) ngx_atomic_fetch_add(ngx_stat_active, 1); +#endif + hc = ngx_palloc(c->pool, sizeof(ngx_http_connection_t)); if (hc == NULL) { ngx_http_close_connection(c);
--- a/src/http/v3/ngx_http_v3_request.c +++ b/src/http/v3/ngx_http_v3_request.c @@ -78,6 +78,10 @@ ngx_http_v3_init(ngx_connection_t *c) ngx_log_debug0(NGX_LOG_DEBUG_HTTP, c->log, 0, "http3 init request stream"); +#if (NGX_STAT_STUB) + (void) ngx_atomic_fetch_add(ngx_stat_active, 1); +#endif + hc = c->data; clcf = ngx_http_get_module_loc_conf(hc->conf_ctx, ngx_http_core_module);