Mercurial > hg > nginx

changeset 5665:46d0795a846c

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
SPDY: avoid sending RST_STREAM on WINDOW_UPDATE with unknown SID. There's a race condition between closing a stream by one endpoint and sending a WINDOW_UPDATE frame by another. So it would be better to just skip such frames for unknown streams, like is already done for the DATA frames.
author Valentin Bartenev <vbart@nginx.com>
date Mon, 21 Apr 2014 19:21:17 +0400
parents de93bbe2d8cd
children a77c0839c993
files src/http/ngx_http_spdy.c
diffstat 1 files changed, 2 insertions(+), 10 deletions(-) [+]
line wrap: on
line diff
--- a/src/http/ngx_http_spdy.c
+++ b/src/http/ngx_http_spdy.c
@@ -1341,16 +1341,8 @@ ngx_http_spdy_state_window_update(ngx_ht
         stream = ngx_http_spdy_get_stream_by_id(sc, sid);
 
         if (stream == NULL) {
-            ngx_log_error(NGX_LOG_INFO, sc->connection->log, 0,
-                          "client sent WINDOW_UPDATE frame "
-                          "for unknown stream %ui", sid);
-
-            if (ngx_http_spdy_send_rst_stream(sc, sid, NGX_SPDY_INVALID_STREAM,
-                                              NGX_SPDY_LOWEST_PRIORITY)
-                == NGX_ERROR)
-            {
-                return ngx_http_spdy_state_internal_error(sc);
-            }
+            ngx_log_debug0(NGX_LOG_DEBUG_HTTP, sc->connection->log, 0,
+                           "unknown spdy stream");
 
             return ngx_http_spdy_state_complete(sc, pos, end);
         }