changeset 8569:a6784cf32c13 quic

QUIC: fixed handling of incorrect packets. Instead of ignoring, connection was closed. This was broken in d0d3fc0697a0.
author Vladimir Homutov <vl@nginx.com>
date Thu, 01 Oct 2020 22:20:51 +0300
parents 0875101c08f7
children 6dac06dfe779
files src/event/ngx_event_quic_transport.c
diffstat 1 files changed, 16 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/src/event/ngx_event_quic_transport.c
+++ b/src/event/ngx_event_quic_transport.c
@@ -256,7 +256,12 @@ ngx_quic_parse_packet(ngx_quic_header_t 
     if (!ngx_quic_long_pkt(pkt->flags)) {
         pkt->level = ssl_encryption_application;
 
-        return ngx_quic_parse_short_header(pkt, NGX_QUIC_SERVER_CID_LEN);
+        if (ngx_quic_parse_short_header(pkt, NGX_QUIC_SERVER_CID_LEN) != NGX_OK)
+        {
+            return NGX_DECLINED;
+        }
+
+        return NGX_OK;
     }
 
     if (ngx_quic_parse_long_header(pkt) != NGX_OK) {
@@ -277,7 +282,11 @@ ngx_quic_parse_packet(ngx_quic_header_t 
 
         pkt->level = ssl_encryption_initial;
 
-        return ngx_quic_parse_initial_header(pkt);
+        if (ngx_quic_parse_initial_header(pkt) != NGX_OK) {
+            return NGX_DECLINED;
+        }
+
+        return NGX_OK;
     }
 
     if (ngx_quic_pkt_hs(pkt->flags)) {
@@ -292,7 +301,11 @@ ngx_quic_parse_packet(ngx_quic_header_t 
          return NGX_DECLINED;
     }
 
-    return ngx_quic_parse_handshake_header(pkt);
+    if (ngx_quic_parse_handshake_header(pkt) != NGX_OK) {
+        return NGX_DECLINED;
+    }
+
+    return NGX_OK;
 }