Mercurial > hg > nginx
changeset 9286:d9fe808c1841
HTTP/3: protection from recursion during connection reuse.
When draining a connection associated with an HTTP/3 stream, calling
ngx_http_v3_send_cancel_stream() might result in an attempt to obtain
a connection for the decoder stream. This in turn will trigger draining
of the very same connection. Depending on the client settings, this
might either lead to stack overflow or will end up in decoder stream
creation error and destroying the connection at some point, potentially
resulting in use-after-free on stack.
Fix is to make sure that connection reuse is disabled in
ngx_http_v3_reset_stream(), so the recursion in question won't happen
regardless of what called functions do.
author | Maxim Dounin <mdounin@mdounin.ru> |
---|---|
date | Sun, 02 Jun 2024 23:51:55 +0300 |
parents | 4c7a9355bcae |
children | 32d4582c484d |
files | src/http/v3/ngx_http_v3_request.c |
diffstat | 1 files changed, 2 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/src/http/v3/ngx_http_v3_request.c +++ b/src/http/v3/ngx_http_v3_request.c @@ -401,6 +401,8 @@ ngx_http_v3_reset_stream(ngx_connection_ ngx_http_v3_session_t *h3c; ngx_http_v3_srv_conf_t *h3scf; + ngx_reusable_connection(c, 0); + h3scf = ngx_http_v3_get_module_srv_conf(c, ngx_http_v3_module); h3c = ngx_http_v3_get_session(c);