Mercurial > hg > nginx

changeset 5026:f3f3083f1253

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
FastCGI: fixed wrong connection close with fastcgi_keep_conn. With fastcgi_keep_conn it was possible that connection was closed after FCGI_STDERR record with zero padding and without any further data read yet. This happended as f->state was set to ngx_http_fastcgi_st_padding and then "break" happened, resulting in p->length being set to f->padding, i.e. 0 (which in turn resulted in connection close). Fix is to make sure we continue the loop after f->state is set.
author Maxim Dounin <mdounin@mdounin.ru>
date Fri, 01 Feb 2013 14:40:19 +0000
parents 43cb2c9799c1
children 2ab25df19dc6
files src/http/modules/ngx_http_fastcgi_module.c
diffstat 1 files changed, 0 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/src/http/modules/ngx_http_fastcgi_module.c
+++ b/src/http/modules/ngx_http_fastcgi_module.c
@@ -1788,10 +1788,6 @@ ngx_http_fastcgi_input_filter(ngx_event_
                               "FastCGI sent in stderr: \"%*s\"",
                               m + 1 - msg, msg);
 
-                if (f->pos == f->last) {
-                    break;
-                }
-
             } else {
                 if (f->padding) {
                     f->state = ngx_http_fastcgi_st_padding;