annotate h2_proxy_ssl.t @ 1961:fe6f22da53ec default tip

Tests: tests for usage of discarded body. The client_max_body_size limit should be ignored when the request body is already discarded. In HTTP/1.x, this is done by checking the r->discard_body flag when the body is being discarded, and because r->headers_in.content_length_n is 0 when it's already discarded. This, however, does not happen with HTTP/2 and HTTP/3, and therefore "error_page 413" does not work without relaxing the limit. Further, with proxy_pass, r->headers_in.content_length_n is used to determine length of the request body, and therefore is not correct if discarding of the request body isn't yet complete. While discarding the request body, r->headers_in.content_length_n contains the rest of the body to discard (or, in case of chunked request body, the rest of the current chunk to discard). Similarly, the $content_length variable uses r->headers_in.content_length if available, and also incorrect. The $content_length variable is used when proxying with fastcgi_pass, grpc_pass, and uwsgi_pass (scgi_pass uses the value calculated based on the actual request body buffers, and therefore works correctly).
author Maxim Dounin <mdounin@mdounin.ru>
date Sat, 27 Apr 2024 18:55:50 +0300
parents 236d038dc04a
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
886
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
1 #!/usr/bin/perl
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
2
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
3 # (C) Sergey Kandaurov
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
4 # (C) Nginx, Inc.
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
5
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
6 # Tests for HTTP/2 protocol with proxy to ssl backend.
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
7
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
8 ###############################################################################
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
9
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
10 use warnings;
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
11 use strict;
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
12
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
13 use Test::More;
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
14
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
15 BEGIN { use FindBin; chdir($FindBin::Bin); }
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
16
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
17 use lib 'lib';
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
18 use Test::Nginx;
948
4dc302d8e04f Tests: changed HTTP2 package to act as a class.
Sergey Kandaurov <pluknet@nginx.com>
parents: 889
diff changeset
19 use Test::Nginx::HTTP2;
886
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
20
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
21 ###############################################################################
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
22
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
23 select STDERR; $| = 1;
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
24 select STDOUT; $| = 1;
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
25
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
26 my $t = Test::Nginx->new()->has(qw/http http_ssl http_v2 proxy/)
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
27 ->has_daemon('openssl')->plan(1);
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
28
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
29 $t->write_file_expand('nginx.conf', <<'EOF');
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
30
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
31 %%TEST_GLOBALS%%
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
32
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
33 daemon off;
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
34
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
35 events {
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
36 }
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
37
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
38 http {
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
39 %%TEST_GLOBALS_HTTP%%
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
40
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
41 server {
974
882267679006 Tests: simplified parallel modifications in tests.
Andrey Zelenkov <zelenkov@nginx.com>
parents: 952
diff changeset
42 listen 127.0.0.1:8080 http2;
882267679006 Tests: simplified parallel modifications in tests.
Andrey Zelenkov <zelenkov@nginx.com>
parents: 952
diff changeset
43 listen 127.0.0.1:8081 ssl;
886
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
44 server_name localhost;
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
45
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
46 ssl_certificate_key localhost.key;
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
47 ssl_certificate localhost.crt;
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
48
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
49 location / { }
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
50 location /proxy_ssl/ {
974
882267679006 Tests: simplified parallel modifications in tests.
Andrey Zelenkov <zelenkov@nginx.com>
parents: 952
diff changeset
51 proxy_pass https://127.0.0.1:8081/;
886
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
52 }
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
53 }
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
54 }
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
55
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
56 EOF
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
57
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
58 $t->write_file('openssl.conf', <<EOF);
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
59 [ req ]
1488
dbce8fb5f5f8 Tests: align with OpenSSL security level 2.
Sergey Kandaurov <pluknet@nginx.com>
parents: 1220
diff changeset
60 default_bits = 2048
886
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
61 encrypt_key = no
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
62 distinguished_name = req_distinguished_name
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
63 [ req_distinguished_name ]
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
64 EOF
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
65
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
66 my $d = $t->testdir();
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
67
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
68 foreach my $name ('localhost') {
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
69 system('openssl req -x509 -new '
1220
0af58b78df35 Tests: removed single quotes from system() calls.
Sergey Kandaurov <pluknet@nginx.com>
parents: 1116
diff changeset
70 . "-config $d/openssl.conf -subj /CN=$name/ "
0af58b78df35 Tests: removed single quotes from system() calls.
Sergey Kandaurov <pluknet@nginx.com>
parents: 1116
diff changeset
71 . "-out $d/$name.crt -keyout $d/$name.key "
886
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
72 . ">>$d/openssl.out 2>&1") == 0
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
73 or die "Can't create certificate for $name: $!\n";
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
74 }
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
75
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
76 $t->write_file('index.html', '');
1900
236d038dc04a Tests: suppress "listen .. http2;" deprecation warnings.
Sergey Kandaurov <pluknet@nginx.com>
parents: 1488
diff changeset
77
236d038dc04a Tests: suppress "listen .. http2;" deprecation warnings.
Sergey Kandaurov <pluknet@nginx.com>
parents: 1488
diff changeset
78 # suppress deprecation warning
236d038dc04a Tests: suppress "listen .. http2;" deprecation warnings.
Sergey Kandaurov <pluknet@nginx.com>
parents: 1488
diff changeset
79
236d038dc04a Tests: suppress "listen .. http2;" deprecation warnings.
Sergey Kandaurov <pluknet@nginx.com>
parents: 1488
diff changeset
80 open OLDERR, ">&", \*STDERR; close STDERR;
886
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
81 $t->run();
1900
236d038dc04a Tests: suppress "listen .. http2;" deprecation warnings.
Sergey Kandaurov <pluknet@nginx.com>
parents: 1488
diff changeset
82 open STDERR, ">&", \*OLDERR;
886
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
83
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
84 ###############################################################################
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
85
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
86 # request body with an empty DATA frame proxied to ssl backend
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
87 # "zero size buf in output" alerts seen
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
88
948
4dc302d8e04f Tests: changed HTTP2 package to act as a class.
Sergey Kandaurov <pluknet@nginx.com>
parents: 889
diff changeset
89 my $s = Test::Nginx::HTTP2->new();
4dc302d8e04f Tests: changed HTTP2 package to act as a class.
Sergey Kandaurov <pluknet@nginx.com>
parents: 889
diff changeset
90 my $sid = $s->new_stream({ path => '/proxy_ssl/', body_more => 1 });
4dc302d8e04f Tests: changed HTTP2 package to act as a class.
Sergey Kandaurov <pluknet@nginx.com>
parents: 889
diff changeset
91 $s->h2_body('');
4dc302d8e04f Tests: changed HTTP2 package to act as a class.
Sergey Kandaurov <pluknet@nginx.com>
parents: 889
diff changeset
92 my $frames = $s->read(all => [{ sid => $sid, fin => 1 }]);
886
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
93
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
94 my ($frame) = grep { $_->{type} eq "HEADERS" } @$frames;
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
95 is($frame->{headers}->{':status'}, 200, 'empty request body');
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
96
af2cd0ba6ca7 Tests: fixed HTTP/2 test for empty request body proxied with https.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
97 ###############################################################################