annotate h2_trailers.t @ 1961:fe6f22da53ec default tip

Tests: tests for usage of discarded body. The client_max_body_size limit should be ignored when the request body is already discarded. In HTTP/1.x, this is done by checking the r->discard_body flag when the body is being discarded, and because r->headers_in.content_length_n is 0 when it's already discarded. This, however, does not happen with HTTP/2 and HTTP/3, and therefore "error_page 413" does not work without relaxing the limit. Further, with proxy_pass, r->headers_in.content_length_n is used to determine length of the request body, and therefore is not correct if discarding of the request body isn't yet complete. While discarding the request body, r->headers_in.content_length_n contains the rest of the body to discard (or, in case of chunked request body, the rest of the current chunk to discard). Similarly, the $content_length variable uses r->headers_in.content_length if available, and also incorrect. The $content_length variable is used when proxying with fastcgi_pass, grpc_pass, and uwsgi_pass (scgi_pass uses the value calculated based on the actual request body buffers, and therefore works correctly).
author Maxim Dounin <mdounin@mdounin.ru>
date Sat, 27 Apr 2024 18:55:50 +0300
parents 236d038dc04a
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
1193
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
1 #!/usr/bin/perl
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
2
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
3 # (C) Sergey Kandaurov
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
4 # (C) Nginx, Inc.
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
5
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
6 # Tests for HTTP/2 trailers.
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
7
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
8 ###############################################################################
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
9
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
10 use warnings;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
11 use strict;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
12
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
13 use Test::More;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
14
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
15 BEGIN { use FindBin; chdir($FindBin::Bin); }
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
16
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
17 use lib 'lib';
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
18 use Test::Nginx;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
19 use Test::Nginx::HTTP2;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
20
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
21 ###############################################################################
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
22
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
23 select STDERR; $| = 1;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
24 select STDOUT; $| = 1;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
25
1381
97c8280de681 Tests: removed TODO and try_run() checks for legacy versions.
Sergey Kandaurov <pluknet@nginx.com>
parents: 1194
diff changeset
26 my $t = Test::Nginx->new()->has(qw/http http_v2/)->plan(22)
1193
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
27 ->write_file_expand('nginx.conf', <<'EOF');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
28
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
29 %%TEST_GLOBALS%%
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
30
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
31 daemon off;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
32
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
33 events {
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
34 }
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
35
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
36 http {
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
37 %%TEST_GLOBALS_HTTP%%
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
38
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
39 server {
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
40 listen 127.0.0.1:8080 http2;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
41 server_name localhost;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
42
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
43 location / {
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
44 add_trailer X-Var $host;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
45 }
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
46
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
47 location /continuation {
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
48 # many trailers to send in parts
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
49 add_trailer X-LongHeader $arg_h;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
50 add_trailer X-LongHeader $arg_h;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
51 add_trailer X-LongHeader $arg_h;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
52 add_trailer X-LongHeader $arg_h;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
53 add_trailer X-LongHeader $arg_h;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
54 }
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
55 }
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
56 }
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
57
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
58 EOF
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
59
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
60 $t->write_file('index.html', 'SEE-THIS');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
61 $t->write_file('empty', '');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
62 $t->write_file('continuation', 'SEE-THIS');
1900
236d038dc04a Tests: suppress "listen .. http2;" deprecation warnings.
Sergey Kandaurov <pluknet@nginx.com>
parents: 1646
diff changeset
63
236d038dc04a Tests: suppress "listen .. http2;" deprecation warnings.
Sergey Kandaurov <pluknet@nginx.com>
parents: 1646
diff changeset
64 # suppress deprecation warning
236d038dc04a Tests: suppress "listen .. http2;" deprecation warnings.
Sergey Kandaurov <pluknet@nginx.com>
parents: 1646
diff changeset
65
236d038dc04a Tests: suppress "listen .. http2;" deprecation warnings.
Sergey Kandaurov <pluknet@nginx.com>
parents: 1646
diff changeset
66 open OLDERR, ">&", \*STDERR; close STDERR;
1381
97c8280de681 Tests: removed TODO and try_run() checks for legacy versions.
Sergey Kandaurov <pluknet@nginx.com>
parents: 1194
diff changeset
67 $t->run();
1900
236d038dc04a Tests: suppress "listen .. http2;" deprecation warnings.
Sergey Kandaurov <pluknet@nginx.com>
parents: 1646
diff changeset
68 open STDERR, ">&", \*OLDERR;
1193
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
69
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
70 ###############################################################################
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
71
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
72 my ($s, $sid, $frames, $frame);
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
73
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
74 $s = Test::Nginx::HTTP2->new();
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
75 $sid = $s->new_stream({ path => '/' });
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
76 $frames = $s->read(all => [{ sid => $sid, fin => 1 }]);
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
77 @$frames = grep { $_->{type} =~ "HEADERS|DATA" } @$frames;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
78
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
79 is(@$frames, 3, 'frames');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
80
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
81 $frame = shift @$frames;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
82 is($frame->{headers}->{':status'}, 200, 'header');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
83 is($frame->{headers}->{'x-var'}, undef, 'header not trailer');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
84 is($frame->{flags}, 4, 'header flags');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
85
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
86 $frame = shift @$frames;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
87 is($frame->{data}, 'SEE-THIS', 'data');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
88 is($frame->{flags}, 0, 'data flags');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
89
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
90 $frame = shift @$frames;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
91 is($frame->{headers}->{'x-var'}, 'localhost', 'trailer');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
92 is($frame->{flags}, 5, 'trailer flags');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
93
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
94 # with zero content-length
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
95
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
96 $s = Test::Nginx::HTTP2->new();
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
97 $sid = $s->new_stream({ path => '/empty' });
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
98 $frames = $s->read(all => [{ sid => $sid, fin => 1 }]);
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
99 @$frames = grep { $_->{type} =~ "HEADERS|DATA" } @$frames;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
100
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
101 is(@$frames, 2, 'no data - frames');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
102
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
103 $frame = shift @$frames;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
104 is($frame->{headers}->{':status'}, 200, 'no data - header');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
105 is($frame->{flags}, 4, 'no data - header flags');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
106
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
107 $frame = shift @$frames;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
108 is($frame->{headers}->{'x-var'}, 'localhost', 'no data - trailer');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
109 is($frame->{flags}, 5, 'no data - trailer flags');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
110
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
111 # CONTINUATION in response trailers
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
112
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
113 $s = Test::Nginx::HTTP2->new();
1646
5b1fa6e32549 Tests: avoid http2_max_field_size in h2_trailers.t.
Sergey Kandaurov <pluknet@nginx.com>
parents: 1381
diff changeset
114 $sid = $s->new_stream({ path => '/continuation?h=' . 'x' x 4000 });
1194
39cfdf581253 Tests: fixed CONTINUATION test in h2_trailers.t.
Sergey Kandaurov <pluknet@nginx.com>
parents: 1193
diff changeset
115 $frames = $s->read(all => [{ sid => $sid, type => 'CONTINUATION' }]);
1193
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
116 @$frames = grep { $_->{type} =~ "HEADERS|CONTINUATION|DATA" } @$frames;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
117
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
118 is(@$frames, 4, 'continuation - frames');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
119
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
120 $frame = shift @$frames;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
121 is($frame->{headers}->{':status'}, 200, 'continuation - header');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
122 is($frame->{flags}, 4, 'continuation - header flags');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
123
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
124 $frame = shift @$frames;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
125 is($frame->{data}, 'SEE-THIS', 'continuation - data');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
126 is($frame->{flags}, 0, 'continuation - data flags');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
127
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
128 $frame = shift @$frames;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
129 is($frame->{type}, 'HEADERS', 'continuation - trailer');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
130 is($frame->{flags}, 1, 'continuation - trailer flags');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
131
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
132 $frame = shift @$frames;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
133 is($frame->{type}, 'CONTINUATION', 'continuation - trailer continuation');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
134 is($frame->{flags}, 4, 'continuation - trailer continuation flags');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
135
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
136 ###############################################################################