annotate trailers.t @ 1961:fe6f22da53ec default tip

Tests: tests for usage of discarded body. The client_max_body_size limit should be ignored when the request body is already discarded. In HTTP/1.x, this is done by checking the r->discard_body flag when the body is being discarded, and because r->headers_in.content_length_n is 0 when it's already discarded. This, however, does not happen with HTTP/2 and HTTP/3, and therefore "error_page 413" does not work without relaxing the limit. Further, with proxy_pass, r->headers_in.content_length_n is used to determine length of the request body, and therefore is not correct if discarding of the request body isn't yet complete. While discarding the request body, r->headers_in.content_length_n contains the rest of the body to discard (or, in case of chunked request body, the rest of the current chunk to discard). Similarly, the $content_length variable uses r->headers_in.content_length if available, and also incorrect. The $content_length variable is used when proxying with fastcgi_pass, grpc_pass, and uwsgi_pass (scgi_pass uses the value calculated based on the actual request body buffers, and therefore works correctly).
author Maxim Dounin <mdounin@mdounin.ru>
date Sat, 27 Apr 2024 18:55:50 +0300
parents 97c8280de681
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
1193
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
1 #!/usr/bin/perl
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
2
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
3 # (C) Sergey Kandaurov
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
4 # (C) Nginx, Inc.
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
5
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
6 # Tests for trailers in headers filter module.
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
7
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
8 ###############################################################################
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
9
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
10 use warnings;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
11 use strict;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
12
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
13 use Test::More;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
14
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
15 use Socket qw/ $CRLF /;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
16
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
17 BEGIN { use FindBin; chdir($FindBin::Bin); }
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
18
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
19 use lib 'lib';
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
20 use Test::Nginx;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
21
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
22 ###############################################################################
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
23
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
24 select STDERR; $| = 1;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
25 select STDOUT; $| = 1;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
26
1381
97c8280de681 Tests: removed TODO and try_run() checks for legacy versions.
Sergey Kandaurov <pluknet@nginx.com>
parents: 1193
diff changeset
27 my $t = Test::Nginx->new()->has(qw/http proxy/)->plan(17)
1193
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
28 ->write_file_expand('nginx.conf', <<'EOF');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
29
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
30 %%TEST_GLOBALS%%
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
31
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
32 daemon off;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
33
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
34 events {
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
35 }
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
36
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
37 http {
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
38 %%TEST_GLOBALS_HTTP%%
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
39
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
40 server {
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
41 listen 127.0.0.1:8080;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
42 server_name localhost;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
43
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
44 add_trailer X-Var $host;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
45 add_trailer X-Always $host always;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
46 add_trailer X-Empty '';
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
47 add_trailer X-Sent-HTTP $sent_http_accept_ranges;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
48 add_trailer X-Sent-Trailer $sent_trailer_x_var;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
49 add_trailer X-Complex $host:$host;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
50
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
51 location /t1 {
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
52 }
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
53
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
54 location /nx {
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
55 }
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
56
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
57 location /header {
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
58 add_header X-Var foo;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
59 }
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
60
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
61 location /empty {
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
62 add_trailer X-Var $host;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
63 }
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
64
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
65 location /not_chunked {
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
66 chunked_transfer_encoding off;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
67 }
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
68
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
69 location /proxy {
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
70 proxy_pass http://127.0.0.1:8080/t1;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
71 add_trailer X-Length $upstream_response_length;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
72 }
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
73 }
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
74 }
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
75
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
76 EOF
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
77
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
78 $t->write_file('t1', 'SEE-THIS');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
79 $t->write_file('header', '');
1381
97c8280de681 Tests: removed TODO and try_run() checks for legacy versions.
Sergey Kandaurov <pluknet@nginx.com>
parents: 1193
diff changeset
80 $t->run();
1193
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
81
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
82 ###############################################################################
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
83
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
84 my $r;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
85
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
86 $r = get('/t1');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
87 like($r, qr/8${CRLF}SEE-THIS${CRLF}0${CRLF}(.+${CRLF}){5}$CRLF/, 'trailers');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
88 unlike($r, qr/X-Var.*SEE-THIS/s, 'not in headers');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
89 like($r, qr/X-Var: localhost/, 'add_trailer');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
90 like($r, qr/X-Always/, 'add_trailer always');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
91 like($r, qr/X-Sent-HTTP: bytes/, 'add_trailer sent_http');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
92 like($r, qr/X-Sent-Trailer: localhost/, 'add_trailer sent_trailer');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
93 like($r, qr/X-Complex: localhost:localhost/, 'add_trailer complex');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
94 unlike($r, qr/X-Empty/, 'add_trailer empty');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
95
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
96 $r = get('/nx');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
97 unlike($r, qr/X-Var/, 'add_trailer bad');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
98 like($r, qr/X-Always/, 'add_trailer bad always');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
99
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
100 like(get('/header'), qr/foo.*^0$CRLF.*X-Var: localhost/ms, 'header name');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
101
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
102 like(http_get('/t1'), qr/${CRLF}SEE-THIS$/, 'no trailers - http10');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
103 unlike(get('/not_chunked'), qr/X-Always/, 'no trailers - not chunked');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
104 unlike(head('/t1'), qr/X-Always/, 'no trailers - head');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
105
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
106 unlike(get('/empty'), qr/X-Var/, 'no trailers expected');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
107
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
108 $r = get('/proxy');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
109 like($r, qr/SEE-THIS.*X-Length: 8/ms, 'upstream response variable');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
110 unlike($r, qr/X-Var/, 'inheritance');
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
111
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
112 ###############################################################################
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
113
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
114 sub get {
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
115 my ($uri) = @_;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
116 http(<<EOF);
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
117 GET $uri HTTP/1.1
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
118 Host: localhost
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
119 Connection: close
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
120
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
121 EOF
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
122 }
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
123
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
124 sub head {
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
125 my ($uri) = @_;
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
126 http(<<EOF);
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
127 HEAD $uri HTTP/1.1
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
128 Host: localhost
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
129 Connection: close
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
130
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
131 EOF
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
132 }
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
133
ae3a46305e38 Tests: add_trailer tests.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
134 ###############################################################################