Mercurial > hg > nginx-tests
comparison h3_limit_req.t @ 1951:1867428f1673
Tests: fixed h3_limit_req.t spurious failures.
In the "reset stream - cancellation" test, HTTP/3 stream is closed without
sending the request body when the request is waiting in the limit_req
module, and this results in error 444. However, when the request is received
with some minor delay due to system load, it is not delayed by limit_req,
and the stream is closed during reading the request body, which results
in error 400 instead, breaking the test.
Fix is to introduce yet another request before the "reset stream" test,
so the stream in question is always delayed by limit_req.
author | Maxim Dounin <mdounin@mdounin.ru> |
---|---|
date | Thu, 14 Mar 2024 02:25:49 +0300 |
parents | 8b74936ff2ac |
children |
comparison
equal
deleted
inserted
replaced
1950:e0b55129fbbf | 1951:1867428f1673 |
---|---|
22 | 22 |
23 select STDERR; $| = 1; | 23 select STDERR; $| = 1; |
24 select STDOUT; $| = 1; | 24 select STDOUT; $| = 1; |
25 | 25 |
26 my $t = Test::Nginx->new()->has(qw/http http_v3 proxy limit_req cryptx/) | 26 my $t = Test::Nginx->new()->has(qw/http http_v3 proxy limit_req cryptx/) |
27 ->has_daemon('openssl')->plan(6); | 27 ->has_daemon('openssl')->plan(7); |
28 | 28 |
29 $t->write_file_expand('nginx.conf', <<'EOF'); | 29 $t->write_file_expand('nginx.conf', <<'EOF'); |
30 | 30 |
31 %%TEST_GLOBALS%% | 31 %%TEST_GLOBALS%% |
32 | 32 |
129 $frames = $s->read(all => [{ sid => $sid, fin => 1 }]); | 129 $frames = $s->read(all => [{ sid => $sid, fin => 1 }]); |
130 | 130 |
131 ($frame) = grep { $_->{type} eq "HEADERS" } @$frames; | 131 ($frame) = grep { $_->{type} eq "HEADERS" } @$frames; |
132 is($frame->{headers}->{':status'}, 200, 'request body - limit req - empty'); | 132 is($frame->{headers}->{':status'}, 200, 'request body - limit req - empty'); |
133 | 133 |
134 # another request | |
135 | |
136 $sid = $s->new_stream({ path => '/' }); | |
137 $frames = $s->read(all => [{ sid => $sid, fin => 1 }]); | |
138 | |
139 ($frame) = grep { $_->{type} eq "HEADERS" } @$frames; | |
140 is($frame->{headers}->{':status'}, '200', 'request body - limit req - next'); | |
141 | |
134 # detect RESET_STREAM while request is delayed | 142 # detect RESET_STREAM while request is delayed |
135 | 143 |
136 $s = Test::Nginx::HTTP3->new(); | 144 $s = Test::Nginx::HTTP3->new(); |
137 $sid = $s->new_stream({ path => '/', body_more => 1 }); | 145 $sid = $s->new_stream({ path => '/', body_more => 1 }); |
138 wait_ack($s); | 146 wait_ack($s); |