diff lib/Test/Nginx/Stream.pm @ 1825:3629eda94c1b

Tests: handling of EWOULDBLOCK from sysread() with IO::Socket::SSL. With IO::Socket::SSL, when select() reports that the socket is readable, reading from it might still fail with EWOULDBLOCK, since no application data is available in the socket. In particular, this might happen with TLSv1.3 when a session ticket is received after the handshake. Fix is to explicitly check for EWOULDBLOCK errors.
author Maxim Dounin <mdounin@mdounin.ru>
date Tue, 21 Mar 2023 02:57:39 +0300
parents 5d3aee48ed8e
children 1197c152215b
line wrap: on
line diff
--- a/lib/Test/Nginx/Stream.pm
+++ b/lib/Test/Nginx/Stream.pm
@@ -84,8 +84,10 @@ sub read {
 	$s = $self->{_socket};
 
 	$s->blocking(0);
-	if (IO::Select->new($s)->can_read($extra{read_timeout} || 8)) {
-		$s->sysread($buf, 1024);
+	while (IO::Select->new($s)->can_read($extra{read_timeout} || 8)) {
+		my $n = $s->sysread($buf, 1024);
+		next if !defined $n && $!{EWOULDBLOCK};
+		last;
 	}
 
 	log_in($buf);