Mercurial > hg > nginx-tests
view not_modified_finalize.t @ 1897:38f1fd9ca3e6
Tests: unbreak reading new stderr data after eof.
Tests don't expect to stop reading redirected stderr when end of file is
reached, but rather to read new data being appended, similar to "tail -f".
The behaviour is found changed in Ubuntu 23.04's Perl 5.36, which applies
the upstream patch [1] expected for inclusion in the upcoming Perl 5.38.
The fix is to clear the filehandle's error state to continue reading.
[1] https://github.com/Perl/perl5/commit/80c1f1e45e8e
Updated mail_error_log.t and stream_error_log.t for consistency.
author | Sergey Kandaurov <pluknet@nginx.com> |
---|---|
date | Mon, 29 May 2023 17:27:11 +0400 |
parents | 5ac6efbe5552 |
children |
line wrap: on
line source
#!/usr/bin/perl # (C) Maxim Dounin # Tests for not modified filter and filter finalization. ############################################################################### use warnings; use strict; use Test::More; BEGIN { use FindBin; chdir($FindBin::Bin); } use lib 'lib'; use Test::Nginx; ############################################################################### select STDERR; $| = 1; select STDOUT; $| = 1; my $t = Test::Nginx->new()->has(qw/http proxy cache/)->plan(2) ->write_file_expand('nginx.conf', <<'EOF'); %%TEST_GLOBALS%% daemon off; events { } http { %%TEST_GLOBALS_HTTP%% proxy_cache_path %%TESTDIR%%/cache keys_zone=cache:1m; server { listen 127.0.0.1:8080; server_name localhost; error_page 412 /error412.html; location / { proxy_pass http://127.0.0.1:8081; proxy_cache cache; proxy_cache_lock on; proxy_cache_valid 1h; } location /error412 { } } server { listen 127.0.0.1:8081; server_name localhost; } } EOF $t->write_file('t.html', 'test file'); $t->write_file('error412.html', 'error412'); $t->run(); ############################################################################### # we trigger filter finalization in not modified filter by using # the If-Unmodified-Since/If-Match header; # with cache enabled and updating bit set, this currently results in # "stalled cache updating" alerts like(http_match_get('/t.html'), qr//, 'request 412'); $t->todo_alerts(); # in addition, in 1.11.10 .. 1.17.1, if the response was previously # cached, such a request resulted in r->cache null pointer dereference # in ngx_http_upstream_cache_background_update(), after it was reset # during internal redirect http_get('/t.html'); like(http_match_get('/t.html'), qr//, 'request 412 cached'); ############################################################################### sub http_match_get { my ($url, %extra) = @_; return http(<<EOF, %extra); GET $url HTTP/1.0 Host: localhost If-Match: tt EOF } ###############################################################################