view geo_unix.t @ 1752:ba6e24e38f03

Tests: improved stop_daemons() to send signal again. As was observed, it's possible that a signal to complete a uwsgi daemon can be ignored while it is starting up, which results in tests hang due to eternal waiting on child processes termination. Notably, it is seen when running tests with a high number of prove jobs on a low-profile VM against nginx with broken modules and/or configuration. To reproduce: $ TEST_NGINX_GLOBALS=ERROR prove -j16 uwsgi*.t Inspecting uwsgi under ktrace on FreeBSD confirms that a SIGTERM signal is ignored at the very beginning of uwsgi startup. It is then replaced with a default action after listen(), thus waiting until uwsgi is ready to accept new TCP connections doesn't completely solve the hang window. The fix is to retry sending a signal some time after waitpid(WNOHANG) continuously demonstrated no progress with reaping a signaled process. It is modelled after f13ead27f89c that improved stop() for nginx.
author Sergey Kandaurov <pluknet@nginx.com>
date Wed, 29 Dec 2021 22:29:23 +0300
parents 5ac6efbe5552
children
line wrap: on
line source

#!/usr/bin/perl

# (C) Sergey Kandaurov
# (C) Nginx, Inc.

# Tests for http geo module with unix socket.

###############################################################################

use warnings;
use strict;

use Test::More;

BEGIN { use FindBin; chdir($FindBin::Bin); }

use lib 'lib';
use Test::Nginx;

###############################################################################

select STDERR; $| = 1;
select STDOUT; $| = 1;

my $t = Test::Nginx->new()->has(qw/http geo proxy unix/)->plan(6);

$t->write_file_expand('nginx.conf', <<'EOF');

%%TEST_GLOBALS%%

daemon off;

events {
}

http {
    %%TEST_GLOBALS_HTTP%%

    geo $geo {
        default                  default;
        255.255.255.255          none;
    }

    geo $remote_addr $geora {
        default                  default;
        255.255.255.255          none;
    }

    geo $geor {
        ranges;
        0.0.0.0-255.255.255.254  test;
        default                  none;
    }

    geo $remote_addr $georra {
        ranges;
        0.0.0.0-255.255.255.254  test;
        default                  none;
    }

    geo $arg_ip $geo_arg {
        default                  default;
        192.0.2.0/24             test;
    }

    server {
        listen       unix:%%TESTDIR%%/unix.sock;
        server_name  localhost;

        location / {
            add_header X-Geo          $geo;
            add_header X-Addr         $geora;
            add_header X-Ranges       $geor;
            add_header X-Ranges-Addr  $georra;
            add_header X-Arg          $geo_arg;
        }
    }

    server {
        listen       127.0.0.1:8080;

        location / {
            proxy_pass http://unix:%%TESTDIR%%/unix.sock;
        }
    }
}

EOF

$t->write_file('index.html', '');
$t->run();

###############################################################################

my $r = http_get('/');
like($r, qr/^X-Geo: none/m, 'geo unix');
like($r, qr/^X-Ranges: none/m, 'geo unix ranges');
like($r, qr/^X-Addr: none/m, 'geo unix remote addr');
like($r, qr/^X-Ranges-Addr: none/m, 'geo unix ranges remote addr');

like(http_get('/?ip=192.0.2.1'), qr/^X-Arg: test/m, 'geo unix variable');

$t->stop();

is(-e $t->testdir() . '/unix.sock', undef, 'unix socket removed');

###############################################################################