Mercurial > hg > nginx-tests
view h2_absolute_redirect.t @ 1752:ba6e24e38f03
Tests: improved stop_daemons() to send signal again.
As was observed, it's possible that a signal to complete a uwsgi daemon
can be ignored while it is starting up, which results in tests hang due
to eternal waiting on child processes termination. Notably, it is seen
when running tests with a high number of prove jobs on a low-profile VM
against nginx with broken modules and/or configuration. To reproduce:
$ TEST_NGINX_GLOBALS=ERROR prove -j16 uwsgi*.t
Inspecting uwsgi under ktrace on FreeBSD confirms that a SIGTERM signal
is ignored at the very beginning of uwsgi startup. It is then replaced
with a default action after listen(), thus waiting until uwsgi is ready
to accept new TCP connections doesn't completely solve the hang window.
The fix is to retry sending a signal some time after waitpid(WNOHANG)
continuously demonstrated no progress with reaping a signaled process.
It is modelled after f13ead27f89c that improved stop() for nginx.
author | Sergey Kandaurov <pluknet@nginx.com> |
---|---|
date | Wed, 29 Dec 2021 22:29:23 +0300 |
parents | 41ca4b00c2d0 |
children | 236d038dc04a |
line wrap: on
line source
#!/usr/bin/perl # (C) Sergey Kandaurov # (C) Nginx, Inc. # Tests for absolute_redirect directive and Location escaping. ############################################################################### use warnings; use strict; use Test::More; BEGIN { use FindBin; chdir($FindBin::Bin); } use lib 'lib'; use Test::Nginx; use Test::Nginx::HTTP2; ############################################################################### select STDERR; $| = 1; select STDOUT; $| = 1; my $t = Test::Nginx->new()->has(qw/http http_v2 proxy rewrite/) ->write_file_expand('nginx.conf', <<'EOF'); %%TEST_GLOBALS%% daemon off; events { } http { %%TEST_GLOBALS_HTTP%% absolute_redirect off; server { listen 127.0.0.1:8080 http2; server_name on; absolute_redirect on; error_page 400 /return301; location / { } location /auto/ { proxy_pass http://127.0.0.1:8080; } location "/auto sp/" { proxy_pass http://127.0.0.1:8080; } location /return301 { return 301 /redirect; } location /return301/name { return 301 /redirect; server_name_in_redirect on; } location /return301/port { return 301 /redirect; port_in_redirect off; } location /i/ { alias %%TESTDIR%%/; } } server { listen 127.0.0.1:8080 http2; server_name off; location / { } location /auto/ { proxy_pass http://127.0.0.1:8080; } location "/auto sp/" { proxy_pass http://127.0.0.1:8080; } location '/auto "#%<>?\^`{|}/' { proxy_pass http://127.0.0.1:8080; } location /return301 { return 301 /redirect; } location /i/ { alias %%TESTDIR%%/; } } } EOF mkdir($t->testdir() . '/dir'); mkdir($t->testdir() . '/dir sp'); $t->run()->plan(23); ############################################################################### my $p = port(8080); like(get('on', '/dir'), qr!Location: http://on:$p/dir/\x0d?$!m, 'directory'); like(get('on', '/i/dir'), qr!Location: http://on:$p/i/dir/\x0d?$!m, 'directory alias'); TODO: { local $TODO = 'not yet' unless $t->has_version('1.21.0'); like(get('on', '/dir%20sp'), qr!Location: http://on:$p/dir%20sp/\x0d?$!m, 'directory escaped'); like(get('on', '/dir%20sp?a=b'), qr!Location: http://on:$p/dir%20sp/\?a=b\x0d?$!m, 'directory escaped args'); } like(get('on', '/auto'), qr!Location: http://on:$p/auto/\x0d?$!m, 'auto'); like(get('on', '/auto?a=b'), qr!Location: http://on:$p/auto/\?a=b\x0d?$!m, 'auto args'); TODO: { local $TODO = 'not yet' unless $t->has_version('1.21.0'); like(get('on', '/auto%20sp'), qr!Location: http://on:$p/auto%20sp/\x0d?$!m, 'auto escaped'); like(get('on', '/auto%20sp?a=b'), qr!Location: http://on:$p/auto%20sp/\?a=b\x0d?$!m, 'auto escaped args'); } like(get('on', '/return301'), qr!Location: http://on:$p/redirect\x0d?$!m, 'return'); like(get('host', '/return301/name'), qr!Location: http://on:$p/redirect\x0d?!m, 'server_name_in_redirect on'); like(get('host', '/return301'), qr!Location: http://host:$p/redirect\x0d?$!m, 'server_name_in_redirect off - using host'); my $ph = IO::Socket::INET->new("127.0.0.1:$p")->peerhost(); like(get('.', '/return301'), qr!Location: http://$ph:$p/redirect\x0d?$!m, 'invalid host - using local sockaddr'); like(get('host', '/return301/port'), qr!Location: http://host/redirect\x0d?$!m, 'port_in_redirect off'); like(get('off', '/dir'), qr!Location: /dir/\x0d?$!m, 'off directory'); like(get('off', '/i/dir'), qr!Location: /i/dir/\x0d?$!m, 'off directory alias'); TODO: { local $TODO = 'not yet' unless $t->has_version('1.21.0'); like(get('off', '/dir%20sp'), qr!Location: /dir%20sp/\x0d?$!m, 'off directory escaped'); like(get('off', '/dir%20sp?a=b'), qr!Location: /dir%20sp/\?a=b\x0d?$!m, 'off directory escaped args'); } like(get('off', '/auto'), qr!Location: /auto/\x0d?$!m, 'off auto'); like(get('off', '/auto?a=b'), qr!Location: /auto/\?a=b\x0d?$!m, 'off auto args'); TODO: { local $TODO = 'not yet' unless $t->has_version('1.21.0'); like(get('off', '/auto%20sp'), qr!Location: /auto%20sp/\x0d?$!m, 'auto escaped'); like(get('off', '/auto%20sp?a=b'), qr!Location: /auto%20sp/\?a=b\x0d?$!m, 'auto escaped args'); } like(get('off', '/return301'), qr!Location: /redirect\x0d?$!m, 'off return'); # per RFC 3986, these characters are not allowed unescaped: # %00-%1F, %7F-%FF, " ", """, "<", ">", "\", "^", "`", "{", "|", "}" # additionally, all characters in ESCAPE_URI: "?", "%", "#" SKIP: { skip 'win32', 1 if $^O eq 'MSWin32'; TODO: { local $TODO = 'not yet' unless $t->has_version('1.21.1'); like(get('off', '/auto%20%22%23%25%3C%3E%3F%5C%5E%60%7B%7C%7D'), qr!Location: /auto%20%22%23%25%3C%3E%3F%5C%5E%60%7B%7C%7D/\x0d?$!m, 'auto escaped strict'); } } ############################################################################### sub get { my ($host, $uri) = @_; my $s = Test::Nginx::HTTP2->new(); my $sid = $s->new_stream({ host => $host, path => $uri }); my $frames = $s->read(all => [{ sid => $sid, fin => 1 }]); my ($frame) = grep { $_->{type} eq "HEADERS" } @$frames; return 'Location: ' . $frame->{headers}->{'location'}; } ###############################################################################