view h2_auth_request.t @ 1752:ba6e24e38f03

Tests: improved stop_daemons() to send signal again. As was observed, it's possible that a signal to complete a uwsgi daemon can be ignored while it is starting up, which results in tests hang due to eternal waiting on child processes termination. Notably, it is seen when running tests with a high number of prove jobs on a low-profile VM against nginx with broken modules and/or configuration. To reproduce: $ TEST_NGINX_GLOBALS=ERROR prove -j16 uwsgi*.t Inspecting uwsgi under ktrace on FreeBSD confirms that a SIGTERM signal is ignored at the very beginning of uwsgi startup. It is then replaced with a default action after listen(), thus waiting until uwsgi is ready to accept new TCP connections doesn't completely solve the hang window. The fix is to retry sending a signal some time after waitpid(WNOHANG) continuously demonstrated no progress with reaping a signaled process. It is modelled after f13ead27f89c that improved stop() for nginx.
author Sergey Kandaurov <pluknet@nginx.com>
date Wed, 29 Dec 2021 22:29:23 +0300
parents 766bcbb632ee
children 236d038dc04a
line wrap: on
line source

#!/usr/bin/perl

# (C) Andrey Zelenkov
# (C) Nginx, Inc.

# Tests for HTTP/2 protocol with auth_request.

###############################################################################

use warnings;
use strict;

use Test::More;

BEGIN { use FindBin; chdir($FindBin::Bin); }

use lib 'lib';
use Test::Nginx;
use Test::Nginx::HTTP2;

###############################################################################

select STDERR; $| = 1;
select STDOUT; $| = 1;

my $t = Test::Nginx->new()->has(qw/http http_v2 rewrite proxy auth_request/)
	->plan(2);

$t->write_file_expand('nginx.conf', <<'EOF');

%%TEST_GLOBALS%%

daemon off;

events {
}

http {
    %%TEST_GLOBALS_HTTP%%

    server {
        listen       127.0.0.1:8080 http2;
        listen       127.0.0.1:8081;
        server_name  localhost;

        location / {
            return 200;
        }
        location /auth {
            add_header X-Body-File $request_body_file;
            client_body_buffer_size 512;
            auth_request /auth_request;
            proxy_pass http://127.0.0.1:8081/auth_proxy;
        }
        location /auth_request {
            proxy_pass http://127.0.0.1:8081/;
            proxy_pass_request_body off;
            proxy_set_header Content-Length "";
        }
        location /auth_proxy {
            add_header X-Body $request_body;
            proxy_pass http://127.0.0.1:8081/;
        }
    }
}

EOF

$t->run();

###############################################################################

my ($s, $sid, $frames, $frame);

# second stream is used to induce body corruption issue

$s = Test::Nginx::HTTP2->new();
$sid = $s->new_stream({ path => '/auth', method => 'POST', body => 'A' x 600 });
$s->new_stream({ path => '/auth', method => 'POST', body => 'B' x 600 });
$frames = $s->read(all => [{ sid => $sid, fin => 1 }]);

($frame) = grep { $_->{type} eq "HEADERS" && $_->{sid} == $sid } @$frames;
is($frame->{headers}->{'x-body'}, 'A' x 600, 'auth request body');
isnt($frame->{headers}->{'x-body-file'}, undef, 'auth request body file');

###############################################################################