view http_include.t @ 1752:ba6e24e38f03

Tests: improved stop_daemons() to send signal again. As was observed, it's possible that a signal to complete a uwsgi daemon can be ignored while it is starting up, which results in tests hang due to eternal waiting on child processes termination. Notably, it is seen when running tests with a high number of prove jobs on a low-profile VM against nginx with broken modules and/or configuration. To reproduce: $ TEST_NGINX_GLOBALS=ERROR prove -j16 uwsgi*.t Inspecting uwsgi under ktrace on FreeBSD confirms that a SIGTERM signal is ignored at the very beginning of uwsgi startup. It is then replaced with a default action after listen(), thus waiting until uwsgi is ready to accept new TCP connections doesn't completely solve the hang window. The fix is to retry sending a signal some time after waitpid(WNOHANG) continuously demonstrated no progress with reaping a signaled process. It is modelled after f13ead27f89c that improved stop() for nginx.
author Sergey Kandaurov <pluknet@nginx.com>
date Wed, 29 Dec 2021 22:29:23 +0300
parents 5ac6efbe5552
children
line wrap: on
line source

#!/usr/bin/perl

# (C) Sergey Kandaurov
# (C) Nginx, Inc.

# Tests for include directive.

###############################################################################

use warnings;
use strict;

use Test::More;

BEGIN { use FindBin; chdir($FindBin::Bin); }

use lib 'lib';
use Test::Nginx;

###############################################################################

select STDERR; $| = 1;
select STDOUT; $| = 1;

my $t = Test::Nginx->new()->has(qw/http rewrite proxy access/)
	->write_file_expand('nginx.conf', <<'EOF');

%%TEST_GLOBALS%%

daemon off;

events {
}

http {
    %%TEST_GLOBALS_HTTP%%

    upstream u {
        include ups.conf;
    }

    server {
        listen       127.0.0.1:8080;
        server_name  localhost;

        if ($arg_s) {
            include sif.conf;
        }

        location / {
            if ($arg_l) {
                include lif.conf;
            }
        }

        location /lmt {
            limit_except GET {
                include lmt.conf;
            }
        }

        location /proxy {
            add_header X-IP $upstream_addr always;
            proxy_pass http://u/backend;
        }

        location /backend { }
    }
}

EOF

my $p = port(8080);

$t->write_file('sif.conf', 'return 200 SIF;');
$t->write_file('lif.conf', 'return 200 LIF;');
$t->write_file('lmt.conf', 'deny all;');
$t->write_file('ups.conf', "server 127.0.0.1:$p;");

$t->run()->plan(5);

###############################################################################

like(http_get('/?s=1'), qr/SIF/, 'include in server if');
like(http_get('/?l=1'), qr/LIF/, 'include in location if');
like(http_post('/lmt'), qr/ 403 /, 'include in limit_except');
like(http_get('/proxy'), qr/X-IP: 127.0.0.1:$p/, 'include in upstream');

unlike(http_get('/'), qr/ 200 /, 'no include');

###############################################################################

sub http_post {
	my ($uri) = @_;
	http(<<EOF);
POST $uri HTTP/1.0
Host: localhost

EOF
}

###############################################################################