Mercurial > hg > nginx-tests
view http_uri.t @ 1752:ba6e24e38f03
Tests: improved stop_daemons() to send signal again.
As was observed, it's possible that a signal to complete a uwsgi daemon
can be ignored while it is starting up, which results in tests hang due
to eternal waiting on child processes termination. Notably, it is seen
when running tests with a high number of prove jobs on a low-profile VM
against nginx with broken modules and/or configuration. To reproduce:
$ TEST_NGINX_GLOBALS=ERROR prove -j16 uwsgi*.t
Inspecting uwsgi under ktrace on FreeBSD confirms that a SIGTERM signal
is ignored at the very beginning of uwsgi startup. It is then replaced
with a default action after listen(), thus waiting until uwsgi is ready
to accept new TCP connections doesn't completely solve the hang window.
The fix is to retry sending a signal some time after waitpid(WNOHANG)
continuously demonstrated no progress with reaping a signaled process.
It is modelled after f13ead27f89c that improved stop() for nginx.
author | Sergey Kandaurov <pluknet@nginx.com> |
---|---|
date | Wed, 29 Dec 2021 22:29:23 +0300 |
parents | e4e711d07e6c |
children | 2a0a6035a1af |
line wrap: on
line source
#!/usr/bin/perl # (C) Sergey Kandaurov # (C) Nginx, Inc. # Tests for URI normalization. ############################################################################### use warnings; use strict; use Test::More; BEGIN { use FindBin; chdir($FindBin::Bin); } use lib 'lib'; use Test::Nginx; ############################################################################### select STDERR; $| = 1; select STDOUT; $| = 1; my $t = Test::Nginx->new()->has(qw/http rewrite/)->plan(19) ->write_file_expand('nginx.conf', <<'EOF')->run(); %%TEST_GLOBALS%% daemon off; events { } http { %%TEST_GLOBALS_HTTP%% server { listen 127.0.0.1:8080; server_name localhost; location / { add_header X-URI "x $uri x"; add_header X-Args "y $args y"; add_header X-Request-URI "z $request_uri z"; return 204; } } } EOF ############################################################################### like(http_get('/foo/bar%'), qr/400 Bad/, 'percent'); like(http_get('/foo/bar%1'), qr/400 Bad/, 'percent digit'); like(http_get('/foo/bar/.?args'), qr!x /foo/bar/ x!, 'dot args'); like(http_get('/foo/bar/.#frag'), qr!x /foo/bar/ x!, 'dot frag'); like(http_get('/foo/bar/..?args'), qr!x /foo/ x!, 'dot dot args'); like(http_get('/foo/bar/..#frag'), qr!x /foo/ x!, 'dot dot frag'); like(http_get('/foo/bar/.'), qr!x /foo/bar/ x!, 'trailing dot'); like(http_get('/foo/bar/..'), qr!x /foo/ x!, 'trailing dot dot'); like(http_get('http://localhost'), qr!x / x!, 'absolute'); like(http_get('http://localhost/'), qr!x / x!, 'absolute slash'); like(http_get('http://localhost?args'), qr!x / x.*y args y!ms, 'absolute args'); like(http_get('http://localhost?args#frag'), qr!x / x.*y args y!ms, 'absolute args and frag'); like(http_get('http://localhost:8080'), qr!x / x!, 'port'); like(http_get('http://localhost:8080/'), qr!x / x!, 'port slash'); like(http_get('http://localhost:8080?args'), qr!x / x.*y args y!ms, 'port args'); like(http_get('http://localhost:8080?args#frag'), qr!x / x.*y args y!ms, 'port args and frag'); TODO: { local $TODO = 'not yet' unless $t->has_version('1.21.1'); like(http_get('/ /'), qr/400 Bad/, 'space'); } TODO: { local $TODO = 'not yet' unless $t->has_version('1.21.1'); like(http_get("/\x02"), qr/400 Bad/, 'control'); } like(http_get('/%02'), qr!x /\x02 x!, 'control escaped'); ###############################################################################