Mercurial > hg > nginx-tests
view not_modified_finalize.t @ 1752:ba6e24e38f03
Tests: improved stop_daemons() to send signal again.
As was observed, it's possible that a signal to complete a uwsgi daemon
can be ignored while it is starting up, which results in tests hang due
to eternal waiting on child processes termination. Notably, it is seen
when running tests with a high number of prove jobs on a low-profile VM
against nginx with broken modules and/or configuration. To reproduce:
$ TEST_NGINX_GLOBALS=ERROR prove -j16 uwsgi*.t
Inspecting uwsgi under ktrace on FreeBSD confirms that a SIGTERM signal
is ignored at the very beginning of uwsgi startup. It is then replaced
with a default action after listen(), thus waiting until uwsgi is ready
to accept new TCP connections doesn't completely solve the hang window.
The fix is to retry sending a signal some time after waitpid(WNOHANG)
continuously demonstrated no progress with reaping a signaled process.
It is modelled after f13ead27f89c that improved stop() for nginx.
author | Sergey Kandaurov <pluknet@nginx.com> |
---|---|
date | Wed, 29 Dec 2021 22:29:23 +0300 |
parents | 5ac6efbe5552 |
children |
line wrap: on
line source
#!/usr/bin/perl # (C) Maxim Dounin # Tests for not modified filter and filter finalization. ############################################################################### use warnings; use strict; use Test::More; BEGIN { use FindBin; chdir($FindBin::Bin); } use lib 'lib'; use Test::Nginx; ############################################################################### select STDERR; $| = 1; select STDOUT; $| = 1; my $t = Test::Nginx->new()->has(qw/http proxy cache/)->plan(2) ->write_file_expand('nginx.conf', <<'EOF'); %%TEST_GLOBALS%% daemon off; events { } http { %%TEST_GLOBALS_HTTP%% proxy_cache_path %%TESTDIR%%/cache keys_zone=cache:1m; server { listen 127.0.0.1:8080; server_name localhost; error_page 412 /error412.html; location / { proxy_pass http://127.0.0.1:8081; proxy_cache cache; proxy_cache_lock on; proxy_cache_valid 1h; } location /error412 { } } server { listen 127.0.0.1:8081; server_name localhost; } } EOF $t->write_file('t.html', 'test file'); $t->write_file('error412.html', 'error412'); $t->run(); ############################################################################### # we trigger filter finalization in not modified filter by using # the If-Unmodified-Since/If-Match header; # with cache enabled and updating bit set, this currently results in # "stalled cache updating" alerts like(http_match_get('/t.html'), qr//, 'request 412'); $t->todo_alerts(); # in addition, in 1.11.10 .. 1.17.1, if the response was previously # cached, such a request resulted in r->cache null pointer dereference # in ngx_http_upstream_cache_background_update(), after it was reset # during internal redirect http_get('/t.html'); like(http_match_get('/t.html'), qr//, 'request 412 cached'); ############################################################################### sub http_match_get { my ($url, %extra) = @_; return http(<<EOF, %extra); GET $url HTTP/1.0 Host: localhost If-Match: tt EOF } ###############################################################################