view scgi_cache.t @ 1752:ba6e24e38f03

Tests: improved stop_daemons() to send signal again. As was observed, it's possible that a signal to complete a uwsgi daemon can be ignored while it is starting up, which results in tests hang due to eternal waiting on child processes termination. Notably, it is seen when running tests with a high number of prove jobs on a low-profile VM against nginx with broken modules and/or configuration. To reproduce: $ TEST_NGINX_GLOBALS=ERROR prove -j16 uwsgi*.t Inspecting uwsgi under ktrace on FreeBSD confirms that a SIGTERM signal is ignored at the very beginning of uwsgi startup. It is then replaced with a default action after listen(), thus waiting until uwsgi is ready to accept new TCP connections doesn't completely solve the hang window. The fix is to retry sending a signal some time after waitpid(WNOHANG) continuously demonstrated no progress with reaping a signaled process. It is modelled after f13ead27f89c that improved stop() for nginx.
author Sergey Kandaurov <pluknet@nginx.com>
date Wed, 29 Dec 2021 22:29:23 +0300
parents 196d33c2bb45
children
line wrap: on
line source

#!/usr/bin/perl

# (C) Maxim Dounin

# Tests for scgi_cache.

###############################################################################

use warnings;
use strict;

use Test::More;
use Socket qw/ CRLF /;

BEGIN { use FindBin; chdir($FindBin::Bin); }

use lib 'lib';
use Test::Nginx;

###############################################################################

select STDERR; $| = 1;
select STDOUT; $| = 1;

eval { require SCGI; };
plan(skip_all => 'SCGI not installed') if $@;

my $t = Test::Nginx->new()->has(qw/http scgi cache/)->plan(10)
	->write_file_expand('nginx.conf', <<'EOF');

%%TEST_GLOBALS%%

daemon off;

events {
}

http {
    %%TEST_GLOBALS_HTTP%%

    scgi_cache_path  %%TESTDIR%%/cache  keys_zone=one:1m;
    scgi_cache_key   $request_uri;

    add_header       X-Cache-Status  $upstream_cache_status;

    server {
        listen       127.0.0.1:8080;
        server_name  localhost;

        location / {
            scgi_pass 127.0.0.1:8081;
            scgi_param SCGI 1;
            scgi_param REQUEST_URI $uri;
            scgi_cache one;
        }
    }
}

EOF

$t->run_daemon(\&scgi_daemon);
$t->run()->waitforsocket('127.0.0.1:' . port(8081));

###############################################################################

like(http_get('/len'), qr/MISS/, 'length');
like(http_get('/len'), qr/HIT/, 'length cached');

like(http_get('/nolen'), qr/MISS/, 'no length');
like(http_get('/nolen'), qr/HIT/, 'no length cached');

like(http_get('/len/empty'), qr/MISS/, 'empty length');
like(http_get('/len/empty'), qr/HIT/, 'empty length cached');

like(http_get('/nolen/empty'), qr/MISS/, 'empty no length');
like(http_get('/nolen/empty'), qr/HIT/, 'empty no length cached');

like(http_get('/unfinished'), qr/MISS/, 'unfinished');
like(http_get('/unfinished'), qr/MISS/, 'unfinished not cached');

###############################################################################

sub scgi_daemon {
	my $server = IO::Socket::INET->new(
		Proto => 'tcp',
		LocalHost => '127.0.0.1:' . port(8081),
		Listen => 5,
		Reuse => 1
	)
		or die "Can't create listening socket: $!\n";

	my $scgi = SCGI->new($server, blocking => 1);
	my %count;

	while (my $request = $scgi->accept()) {
		eval { $request->read_env(); };
		next if $@;

		my $uri = $request->env->{REQUEST_URI} || '';
		my $c = $request->connection();

		$count{$uri} ||= 0;
		$count{$uri}++;

		if ($uri eq '/len') {
			$c->print(
				"Content-Length: 9" . CRLF .
				"Content-Type: text/html" . CRLF .
				"Cache-Control: max-age=300" . CRLF . CRLF .
				"test body"
			);

		} elsif ($uri eq '/nolen') {
			$c->print(
				"Content-Type: text/html" . CRLF .
				"Cache-Control: max-age=300" . CRLF . CRLF .
				"test body"
			);

		} elsif ($uri eq '/len/empty') {
			$c->print(
				"Content-Length: 0" . CRLF .
				"Content-Type: text/html" . CRLF .
				"Cache-Control: max-age=300" . CRLF . CRLF
			);

		} elsif ($uri eq '/nolen/empty') {
			$c->print(
				"Content-Type: text/html" . CRLF .
				"Cache-Control: max-age=300" . CRLF . CRLF
			);

		} elsif ($uri eq '/unfinished') {
			$c->print(
				"Content-Length: 10" . CRLF .
				"Content-Type: text/html" . CRLF .
				"Cache-Control: max-age=300" . CRLF . CRLF
			);
		}
	}
}

###############################################################################