Mercurial > hg > nginx-tests
view dav_chunked.t @ 1905:f35824e75b66
Tests: fixed reading QUIC streams on Perl < 5.24.
The parse_stream() routine has had a missing explicit return if there were no
streams received. In Perl < 5.24 this used to return no value, or an empty
array in the list context. In modern Perl this returns an empty value, or an
array of 1 element, which made the check for last index of the returned array
work rather by accident.
The fix is to return explicitly and to check the array size in callers instead.
author | Sergey Kandaurov <pluknet@nginx.com> |
---|---|
date | Tue, 06 Jun 2023 18:50:07 +0400 |
parents | 882267679006 |
children |
line wrap: on
line source
#!/usr/bin/perl # (C) Maxim Dounin # Tests for nginx dav module with chunked request body. ############################################################################### use warnings; use strict; use Test::More; use Socket qw/ CRLF /; BEGIN { use FindBin; chdir($FindBin::Bin); } use lib 'lib'; use Test::Nginx; ############################################################################### select STDERR; $| = 1; select STDOUT; $| = 1; my $t = Test::Nginx->new()->has(qw/http dav/)->plan(6); $t->write_file_expand('nginx.conf', <<'EOF'); %%TEST_GLOBALS%% daemon off; events { } http { %%TEST_GLOBALS_HTTP%% server { listen 127.0.0.1:8080; server_name localhost; client_header_buffer_size 1k; client_body_buffer_size 2k; location / { dav_methods PUT; } } } EOF $t->run(); ############################################################################### my $r; $r = http(<<EOF); PUT /file HTTP/1.1 Host: localhost Connection: close Transfer-Encoding: chunked a 1234567890 0 EOF like($r, qr/201 Created.*(Content-Length|\x0d\0a0\x0d\x0a)/ms, 'put chunked'); is($t->read_file('file'), '1234567890', 'put content'); $r = http(<<EOF); PUT /file HTTP/1.1 Host: localhost Connection: close Transfer-Encoding: chunked 0 EOF like($r, qr/204 No Content/, 'put chunked empty'); is($t->read_file('file'), '', 'put empty content'); my $body = ('a' . CRLF . '1234567890' . CRLF) x 1024 . '0' . CRLF . CRLF; $r = http(<<EOF); PUT /file HTTP/1.1 Host: localhost Connection: close Transfer-Encoding: chunked $body EOF like($r, qr/204 No Content/, 'put chunked big'); is($t->read_file('file'), '1234567890' x 1024, 'put big content'); ###############################################################################